Closed Bug 1301421 Opened 3 years ago Closed 3 years ago

browser.fixup.dns_first_for_single_words prevents location bar search suggestions even when there's more than one token and/or the first token is not a single word

Categories

(Firefox :: Address Bar, defect, P2)

51 Branch
defect

Tracking

()

RESOLVED FIXED
Firefox 51
Tracking Status
firefox51 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxsearch])

+++ This bug was initially created as a clone of Bug #1294496 +++

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20160811030201

Steps to reproduce:

Enable search suggestions in the location bar and set:

    browser.fixup.dns_first_for_single_words = true


Actual results:

Observe how search suggestions in the location bar don't work, even for multiple tokens.


Expected results:

Per discussion in bug 1294496: we don't want to enable search suggestions for "foo" if the nsIDefaultURIFixup component suggests that "foo" is whitelisted, to avoid privacy issues. This is the case both when "foo" is individually whitelisted and when the dns_first pref is flipped (which means nsIDefaultURIFixup will return true for any host when asked isDomainWhitelisted) . 

However, search suggestions *for multiple words* or when the first word is clearly not a domain should work even with this option enabled.

The original patch and review for this were done in bug 1294496.
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1b0b9ddb452
allow search suggestions for multi-word searches even for whitelisted domains, and test response to "DNS first" pref, r=mak
https://hg.mozilla.org/mozilla-central/rev/c1b0b9ddb452
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
You need to log in before you can comment on or make changes to this bug.