1301426 - Mochitests for promise-based HTMLMediaElement::play()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Tzuhao Kuo [:kaku]]

Follow bug 1244768 comment 71.

Comment 1

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1301426 part 1 - implement helper functions;

Review commit: https://reviewboard.mozilla.org/r/77694/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77694/

Comment 2

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1301426 part 2 - test case 1;

Case: invoke play() on an element that doesn't have enough data
Expected result: resolve the promise

Review commit: https://reviewboard.mozilla.org/r/77696/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77696/

Comment 3

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1301426 part 3 - test case 2;

Case: invoke play() on an element that has enough data
Expected result: resolve the promise

Review commit: https://reviewboard.mozilla.org/r/77698/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77698/

Comment 4

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1301426 part 4 - test case 3;

Case: invoke play() on an element that is already playing.
Expected result: resolve the promise.

Review commit: https://reviewboard.mozilla.org/r/77700/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77700/

Comment 5

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1301426 part 5 - test case 4;

Case: invoke play() on an element with an unsupported content.
Expected result: reject the promis.e

Review commit: https://reviewboard.mozilla.org/r/77702/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77702/

Comment 6

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1301426 part 6 - test case 5;

Case: invoke play() on an element with MEDIA_ERR_SRC_NOT_SUPPORTED has been set.
Expected result: reject the promise.

Review commit: https://reviewboard.mozilla.org/r/77704/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77704/

Comment 7

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1301426 part 7 - test case 6;

Case: invoke play() on an element which had its source changed (to a valid source) after suffering from an error.
Expected result: resolve the promise.

Review commit: https://reviewboard.mozilla.org/r/77706/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77706/

Comment 8

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1301426 part 8 - test case 7;

Case: invoke play() on an element which had its source changed (to a invalid source) after suffering from an error.
Expected result: reject the promise.

Review commit: https://reviewboard.mozilla.org/r/77708/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77708/

Comment 9

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1301426 part 9 - test case 8;

Case: invlke play() and the pause() on an element that already has enough data to play.
Expected result: resolve the promise.

Review commit: https://reviewboard.mozilla.org/r/77710/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77710/

Comment 10

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1301426 part 10 - test case 9;

Case: invlke play() and the pause() on an element that deoen't have enough data to play.
Expected result: reject the promise.

Review commit: https://reviewboard.mozilla.org/r/77712/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77712/

Comment 11

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1301426 part 11 - test case 10;

Case: invoke load() on an element with pending promises.
Expected result: reject all the pending promises.

Review commit: https://reviewboard.mozilla.org/r/77714/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77714/

Comment 12

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1301426 part 12 - test case 11;

Case: change src of an element with pending promises.
Expected result: reject all the pending promises.

Review commit: https://reviewboard.mozilla.org/r/77716/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77716/

Comment 13

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1301426 part 13 - test case 12;

Case:: invoke pause() and then play() on an element that is already playing.
Expected result: resolve the promise.

Review commit: https://reviewboard.mozilla.org/r/77718/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77718/

Comment 14

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1301426 part 14 - test case 13;

Case: re-invoke the load() on an element which had dispatched a task to resolve a promise.
Expected result: the already dispatched promise should still be resolved.

Review commit: https://reviewboard.mozilla.org/r/77720/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77720/

Comment 15

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1301426 part 15 - test case 14;

Case: step1: create an element with its paused member to be fause and networkState to be NETWORK_EMPTY.
      stpe2: invoke load() on the element and the load() leaves the promise pending.
Expected result: the pending promise should finally be resolved.

Review commit: https://reviewboard.mozilla.org/r/77722/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77722/

Comment 16

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1301426 part 16 - test case 15;

Case: step1: create an element with its paused member to be fause and networkState to be NETWORK_NO_SOURCE.
      stpe2: invoke load() on the element and the load() rejects the pending promise.
Expected result: reject the pending promise.

Review commit: https://reviewboard.mozilla.org/r/77724/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77724/

Comment 17

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1301426 part 17 - test case 16;

Case: invoke load() on an element should resolve pending promises in order.
Expected result: the pending promises are resolved in order.

Review commit: https://reviewboard.mozilla.org/r/77726/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77726/

Comment 18

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1301426 part 18 - test case 17;

Case: invoke load() on an element should reject pending promises in order.
Expected result: the pending promises are rejected in order.

Review commit: https://reviewboard.mozilla.org/r/77728/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77728/

Comment 19

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8789512 [details]
Bug 1301426 part 1 - implement helper functions;

https://reviewboard.mozilla.org/r/77694/#review76156

Comment 20

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8789513 [details]
Bug 1301426 part 2 - test case 1;

https://reviewboard.mozilla.org/r/77696/#review76158

Comment 21

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8789514 [details]
Bug 1301426 part 3 - test case 2;

https://reviewboard.mozilla.org/r/77698/#review76160

Comment 22

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8789515 [details]
Bug 1301426 part 4 - test case 3;

https://reviewboard.mozilla.org/r/77700/#review76162

::: dom/media/test/test_play_promise_3.html:35
(Diff revision 1)
> +      (msg) => { ok(true, msg); manager.finished(token); },
> +      (msg) => { ok(false, msg); manager.finished(token); }
> +    );
> +  });
> +
> +  once(element, "canplaythrough").then(() => {

We should just call play() without waiting for 'canplaythrough', right? I can't see how waiting for 'canplaythrough' is relevant to this test case.

Comment 23

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8789516 [details]
Bug 1301426 part 5 - test case 4;

https://reviewboard.mozilla.org/r/77702/#review76164

::: dom/media/test/test_play_promise_4.html:26
(Diff revision 1)
> +
> +  let element = document.createElement(getMajorMimeType(test.type));
> +  element.src = getNotSupportedFile(test.name);
> +  invokePlayShouldBeRejectedWithError("playNotSupportedContent", element, token, "NotSupportedError")
> +  .then(
> +    (msg) => { ok(true, msg); manager.finished(token); },

It is kinda confusing that this promise is resolved when the play promise is rejected. It would be clearer to call play() directly (without using the helper function) and check the resolved/rejected values in this test case.

Comment 24

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8789517 [details]
Bug 1301426 part 6 - test case 5;

https://reviewboard.mozilla.org/r/77704/#review76166

::: dom/media/test/test_play_promise_5.html:28
(Diff revision 1)
> +  element.src = getNotSupportedFile(test.name);
> +  once(element, "error").then(() => {
> +    ok(element.error.code == MediaError.MEDIA_ERR_SRC_NOT_SUPPORTED);
> +    invokePlayShouldBeRejectedWithError("playWithErrorAlreadySet", element, token, "NotSupportedError")
> +    .then(
> +      (msg) => { ok(true, msg); manager.finished(token); },

The same issue as the previosu test case.

Comment 25

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8789518 [details]
Bug 1301426 part 7 - test case 6;

https://reviewboard.mozilla.org/r/77706/#review76168

Comment 26

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8789519 [details]
Bug 1301426 part 8 - test case 7;

https://reviewboard.mozilla.org/r/77708/#review76170

Comment 27

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8789520 [details]
Bug 1301426 part 9 - test case 8;

https://reviewboard.mozilla.org/r/77710/#review76172

::: dom/media/test/test_play_promise_8.html:14
(Diff revision 1)
> +</head>
> +<body>
> +<pre id="test">
> +
> +<script>
> +// Case: invlke play() and the pause() on an element that already has enough data to play

and 'then' pause()

Comment 28

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8789521 [details]
Bug 1301426 part 10 - test case 9;

https://reviewboard.mozilla.org/r/77712/#review76174

::: dom/media/test/test_play_promise_9.html:14
(Diff revision 1)
> +</head>
> +<body>
> +<pre id="test">
> +
> +<script>
> +// Case: invlke play() and the pause() on an element that deoen't have enough data to play.

and 'then' pause()

Comment 29

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8789522 [details]
Bug 1301426 part 11 - test case 10;

https://reviewboard.mozilla.org/r/77714/#review76176

Comment 30

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8789523 [details]
Bug 1301426 part 12 - test case 11;

https://reviewboard.mozilla.org/r/77716/#review76178

Comment 31

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8789524 [details]
Bug 1301426 part 13 - test case 12;

https://reviewboard.mozilla.org/r/77718/#review76180

Comment 32

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8789525 [details]
Bug 1301426 part 14 - test case 13;

https://reviewboard.mozilla.org/r/77720/#review76182

Comment 33

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8789526 [details]
Bug 1301426 part 15 - test case 14;

https://reviewboard.mozilla.org/r/77722/#review76184

::: dom/media/test/test_play_promise_14.html:33
(Diff revision 1)
> +  .then(
> +    (msg) => { ok(true, msg); manager.finished(token); },
> +    (msg) => { ok(false, msg); manager.finished(token); }
> +  );
> +
> +  once(element, "play").then(() => {

How can we make sure the 'play' handler happens before the play promise is resolved? Is it because the play promise won't be resolved until we assign a valid media resource to it?

::: dom/media/test/test_play_promise_14.html:34
(Diff revision 1)
> +    (msg) => { ok(true, msg); manager.finished(token); },
> +    (msg) => { ok(false, msg); manager.finished(token); }
> +  );
> +
> +  once(element, "play").then(() => {
> +    // The resouce selection algorithm has been done -> set the networkState to be NETWORK_EMPTY.

Add a comment to note that the networkState becomes NETWORK_EMPTY because there is no valid resource to load.

Comment 34

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8789527 [details]
Bug 1301426 part 16 - test case 15;

https://reviewboard.mozilla.org/r/77724/#review76186

Comment 35

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8789528 [details]
Bug 1301426 part 17 - test case 16;

https://reviewboard.mozilla.org/r/77726/#review76188

Comment 36

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8789529 [details]
Bug 1301426 part 18 - test case 17;

https://reviewboard.mozilla.org/r/77728/#review76190

Comment 37

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789526 [details]
Bug 1301426 part 15 - test case 14;

https://reviewboard.mozilla.org/r/77722/#review76184

> How can we make sure the 'play' handler happens before the play promise is resolved? Is it because the play promise won't be resolved until we assign a valid media resource to it?

For a valid and successful play() operation, the order of resulting events are always "play" -> "playing" -> "promise resolving". 

> Is it because the play promise won't be resolved until we assign a valid media resource to it?

This is also right. Invoke play() on an element without soruce still dispatch the 'play' event but not the 'playing' event, of course not resoving the promise.

Comment 38

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1301426 part 19 - test case 18;

Review commit: https://reviewboard.mozilla.org/r/95352/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95352/

Comment 39

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789512 [details]
Bug 1301426 part 1 - implement helper functions;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77694/diff/1-2/

Comment 40

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789513 [details]
Bug 1301426 part 2 - test case 1;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77696/diff/1-2/

Comment 41

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789514 [details]
Bug 1301426 part 3 - test case 2;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77698/diff/1-2/

Comment 42

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789515 [details]
Bug 1301426 part 4 - test case 3;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77700/diff/1-2/

Comment 43

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789516 [details]
Bug 1301426 part 5 - test case 4;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77702/diff/1-2/

Comment 44

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789517 [details]
Bug 1301426 part 6 - test case 5;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77704/diff/1-2/

Comment 45

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789518 [details]
Bug 1301426 part 7 - test case 6;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77706/diff/1-2/

Comment 46

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789519 [details]
Bug 1301426 part 8 - test case 7;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77708/diff/1-2/

Comment 47

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789520 [details]
Bug 1301426 part 9 - test case 8;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77710/diff/1-2/

Comment 48

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789521 [details]
Bug 1301426 part 10 - test case 9;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77712/diff/1-2/

Comment 49

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789522 [details]
Bug 1301426 part 11 - test case 10;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77714/diff/1-2/

Comment 50

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789523 [details]
Bug 1301426 part 12 - test case 11;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77716/diff/1-2/

Comment 51

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789524 [details]
Bug 1301426 part 13 - test case 12;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77718/diff/1-2/

Comment 52

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789525 [details]
Bug 1301426 part 14 - test case 13;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77720/diff/1-2/

Comment 53

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789526 [details]
Bug 1301426 part 15 - test case 14;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77722/diff/1-2/

Comment 54

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789527 [details]
Bug 1301426 part 16 - test case 15;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77724/diff/1-2/

Comment 55

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789528 [details]
Bug 1301426 part 17 - test case 16;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77726/diff/1-2/

Comment 56

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789529 [details]
Bug 1301426 part 18 - test case 17;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77728/diff/1-2/

Comment 57

[Tzuhao Kuo [:kaku]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5b40b927939aa6f4759c950c7bdd48c56708e34
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1b428f766d7df3d895507eb3bb73925624093df1

Comment 58

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8814037 [details]
Bug 1301426 part 19 - test case 18;

https://reviewboard.mozilla.org/r/95352/#review96382

Comment 59

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789512 [details]
Bug 1301426 part 1 - implement helper functions;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77694/diff/2-3/

Comment 60

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789513 [details]
Bug 1301426 part 2 - test case 1;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77696/diff/2-3/

Comment 61

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789514 [details]
Bug 1301426 part 3 - test case 2;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77698/diff/2-3/

Comment 62

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789515 [details]
Bug 1301426 part 4 - test case 3;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77700/diff/2-3/

Comment 63

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789516 [details]
Bug 1301426 part 5 - test case 4;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77702/diff/2-3/

Comment 64

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789517 [details]
Bug 1301426 part 6 - test case 5;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77704/diff/2-3/

Comment 65

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789518 [details]
Bug 1301426 part 7 - test case 6;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77706/diff/2-3/

Comment 66

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789519 [details]
Bug 1301426 part 8 - test case 7;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77708/diff/2-3/

Comment 67

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789520 [details]
Bug 1301426 part 9 - test case 8;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77710/diff/2-3/

Comment 68

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789521 [details]
Bug 1301426 part 10 - test case 9;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77712/diff/2-3/

Comment 69

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789522 [details]
Bug 1301426 part 11 - test case 10;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77714/diff/2-3/

Comment 70

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789523 [details]
Bug 1301426 part 12 - test case 11;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77716/diff/2-3/

Comment 71

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789524 [details]
Bug 1301426 part 13 - test case 12;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77718/diff/2-3/

Comment 72

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789525 [details]
Bug 1301426 part 14 - test case 13;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77720/diff/2-3/

Comment 73

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789526 [details]
Bug 1301426 part 15 - test case 14;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77722/diff/2-3/

Comment 74

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789527 [details]
Bug 1301426 part 16 - test case 15;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77724/diff/2-3/

Comment 75

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789528 [details]
Bug 1301426 part 17 - test case 16;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77726/diff/2-3/

Comment 76

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789529 [details]
Bug 1301426 part 18 - test case 17;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77728/diff/2-3/

Comment 77

[Tzuhao Kuo [:kaku]]

Comment on attachment 8814037 [details]
Bug 1301426 part 19 - test case 18;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/95352/diff/1-2/

Comment 78

[Tzuhao Kuo [:kaku]]

Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9d28406055ffc6b7de7ef09e011cc18253ad7e5e
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c150e6687b8b11d353311c361ad90d689fdc0c63

Comment 79

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789512 [details]
Bug 1301426 part 1 - implement helper functions;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77694/diff/3-4/

Comment 80

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789513 [details]
Bug 1301426 part 2 - test case 1;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77696/diff/3-4/

Comment 81

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789514 [details]
Bug 1301426 part 3 - test case 2;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77698/diff/3-4/

Comment 82

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789515 [details]
Bug 1301426 part 4 - test case 3;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77700/diff/3-4/

Comment 83

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789516 [details]
Bug 1301426 part 5 - test case 4;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77702/diff/3-4/

Comment 84

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789517 [details]
Bug 1301426 part 6 - test case 5;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77704/diff/3-4/

Comment 85

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789518 [details]
Bug 1301426 part 7 - test case 6;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77706/diff/3-4/

Comment 86

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789519 [details]
Bug 1301426 part 8 - test case 7;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77708/diff/3-4/

Comment 87

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789520 [details]
Bug 1301426 part 9 - test case 8;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77710/diff/3-4/

Comment 88

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789521 [details]
Bug 1301426 part 10 - test case 9;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77712/diff/3-4/

Comment 89

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789522 [details]
Bug 1301426 part 11 - test case 10;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77714/diff/3-4/

Comment 90

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789523 [details]
Bug 1301426 part 12 - test case 11;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77716/diff/3-4/

Comment 91

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789524 [details]
Bug 1301426 part 13 - test case 12;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77718/diff/3-4/

Comment 92

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789525 [details]
Bug 1301426 part 14 - test case 13;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77720/diff/3-4/

Comment 93

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789526 [details]
Bug 1301426 part 15 - test case 14;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77722/diff/3-4/

Comment 94

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789527 [details]
Bug 1301426 part 16 - test case 15;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77724/diff/3-4/

Comment 95

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789528 [details]
Bug 1301426 part 17 - test case 16;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77726/diff/3-4/

Comment 96

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789529 [details]
Bug 1301426 part 18 - test case 17;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77728/diff/3-4/

Comment 97

[Tzuhao Kuo [:kaku]]

Comment on attachment 8814037 [details]
Bug 1301426 part 19 - test case 18;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/95352/diff/2-3/

Comment 98

[Tzuhao Kuo [:kaku]]

Rebasing onto bug 1321497.

Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d20fb6faf0bfe1a488ca4611716c977b18119ce7
https://treeherder.mozilla.org/#/jobs?repo=try&revision=15bb251c5243fca0bd47641717a69dda74b8ae82

Comment 99

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789512 [details]
Bug 1301426 part 1 - implement helper functions;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77694/diff/4-5/

Comment 100

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789513 [details]
Bug 1301426 part 2 - test case 1;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77696/diff/4-5/

Comment 101

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789514 [details]
Bug 1301426 part 3 - test case 2;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77698/diff/4-5/

Comment 102

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789515 [details]
Bug 1301426 part 4 - test case 3;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77700/diff/4-5/

Comment 103

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789516 [details]
Bug 1301426 part 5 - test case 4;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77702/diff/4-5/

Comment 104

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789517 [details]
Bug 1301426 part 6 - test case 5;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77704/diff/4-5/

Comment 105

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789518 [details]
Bug 1301426 part 7 - test case 6;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77706/diff/4-5/

Comment 106

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789519 [details]
Bug 1301426 part 8 - test case 7;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77708/diff/4-5/

Comment 107

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789520 [details]
Bug 1301426 part 9 - test case 8;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77710/diff/4-5/

Comment 108

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789521 [details]
Bug 1301426 part 10 - test case 9;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77712/diff/4-5/

Comment 109

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789522 [details]
Bug 1301426 part 11 - test case 10;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77714/diff/4-5/

Comment 110

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789523 [details]
Bug 1301426 part 12 - test case 11;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77716/diff/4-5/

Comment 111

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789524 [details]
Bug 1301426 part 13 - test case 12;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77718/diff/4-5/

Comment 112

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789525 [details]
Bug 1301426 part 14 - test case 13;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77720/diff/4-5/

Comment 113

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789526 [details]
Bug 1301426 part 15 - test case 14;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77722/diff/4-5/

Comment 114

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789527 [details]
Bug 1301426 part 16 - test case 15;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77724/diff/4-5/

Comment 115

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789528 [details]
Bug 1301426 part 17 - test case 16;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77726/diff/4-5/

Comment 116

[Tzuhao Kuo [:kaku]]

Comment on attachment 8789529 [details]
Bug 1301426 part 18 - test case 17;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77728/diff/4-5/

Comment 117

[Tzuhao Kuo [:kaku]]

Comment on attachment 8814037 [details]
Bug 1301426 part 19 - test case 18;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/95352/diff/3-4/

Comment 118

[Tzuhao Kuo [:kaku]]

Try: 
https://treeherder.mozilla.org/#/jobs?repo=try&revision=24767d132c732afb822803c9ec383319795e9352
https://treeherder.mozilla.org/#/jobs?repo=try&revision=54c6cbd7b6bc3e9ba31cb287f73107d943e237a2

Comment 119

[Tzuhao Kuo [:kaku]]

Try looks good! Thanks for reviews!

Comment 120

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3022d045808d
part 1 - implement helper functions; r=jwwang
https://hg.mozilla.org/integration/autoland/rev/fe6a6213ad78
part 2 - test case 1; r=jwwang
https://hg.mozilla.org/integration/autoland/rev/8c29980a4c22
part 3 - test case 2; r=jwwang
https://hg.mozilla.org/integration/autoland/rev/d3b6ec3f3c6a
part 4 - test case 3; r=jwwang
https://hg.mozilla.org/integration/autoland/rev/8946df884a6f
part 5 - test case 4; r=jwwang
https://hg.mozilla.org/integration/autoland/rev/b1c958a86d87
part 6 - test case 5; r=jwwang
https://hg.mozilla.org/integration/autoland/rev/094826abc0e7
part 7 - test case 6; r=jwwang
https://hg.mozilla.org/integration/autoland/rev/6caab9b2dbeb
part 8 - test case 7; r=jwwang
https://hg.mozilla.org/integration/autoland/rev/c444d693373e
part 9 - test case 8; r=jwwang
https://hg.mozilla.org/integration/autoland/rev/95b156f55a2d
part 10 - test case 9; r=jwwang
https://hg.mozilla.org/integration/autoland/rev/29d8085fd77d
part 11 - test case 10; r=jwwang
https://hg.mozilla.org/integration/autoland/rev/7c73bc8bc144
part 12 - test case 11; r=jwwang
https://hg.mozilla.org/integration/autoland/rev/876048fb7c8f
part 13 - test case 12; r=jwwang
https://hg.mozilla.org/integration/autoland/rev/cb5d7ef529bd
part 14 - test case 13; r=jwwang
https://hg.mozilla.org/integration/autoland/rev/209ee261ba6c
part 15 - test case 14; r=jwwang
https://hg.mozilla.org/integration/autoland/rev/d59d582c6dfc
part 16 - test case 15; r=jwwang
https://hg.mozilla.org/integration/autoland/rev/f3d6fedbddab
part 17 - test case 16; r=jwwang
https://hg.mozilla.org/integration/autoland/rev/e6a5e973ffef
part 18 - test case 17; r=jwwang
https://hg.mozilla.org/integration/autoland/rev/a7ffc4485fa5
part 19 - test case 18; r=jwwang

Comment 121

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3022d045808d
https://hg.mozilla.org/mozilla-central/rev/fe6a6213ad78
https://hg.mozilla.org/mozilla-central/rev/8c29980a4c22
https://hg.mozilla.org/mozilla-central/rev/d3b6ec3f3c6a
https://hg.mozilla.org/mozilla-central/rev/8946df884a6f
https://hg.mozilla.org/mozilla-central/rev/b1c958a86d87
https://hg.mozilla.org/mozilla-central/rev/094826abc0e7
https://hg.mozilla.org/mozilla-central/rev/6caab9b2dbeb
https://hg.mozilla.org/mozilla-central/rev/c444d693373e
https://hg.mozilla.org/mozilla-central/rev/95b156f55a2d
https://hg.mozilla.org/mozilla-central/rev/29d8085fd77d
https://hg.mozilla.org/mozilla-central/rev/7c73bc8bc144
https://hg.mozilla.org/mozilla-central/rev/876048fb7c8f
https://hg.mozilla.org/mozilla-central/rev/cb5d7ef529bd
https://hg.mozilla.org/mozilla-central/rev/209ee261ba6c
https://hg.mozilla.org/mozilla-central/rev/d59d582c6dfc
https://hg.mozilla.org/mozilla-central/rev/f3d6fedbddab
https://hg.mozilla.org/mozilla-central/rev/e6a5e973ffef
https://hg.mozilla.org/mozilla-central/rev/a7ffc4485fa5