In nsSVGMaskFrame::GetMaskForMaskedFrame, create surface by Factory::CreateDataSourceSurface

RESOLVED FIXED in Firefox 52

Status

()

Core
Layout
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: cjku, Assigned: vliu)

Tracking

unspecified
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

a year ago
In Bug 1301353 comment 3, mstange said:
why are we obtaining the surface by snapshotting an unused DrawTarget? We should create it through Factory::CreateDataSourceSurface.

Updated

a year ago
Assignee: cku → ethlin
(Assignee)

Comment 1

a year ago
I will take this issue for the following.
Assignee: ethlin → vliu
(Assignee)

Comment 2

a year ago
Created attachment 8796447 [details] [diff] [review]
In nsSVGMaskFrame::GetMaskForMaskedFrame, create surface by Factory::CreateDataSourceSurface.

Hi Markus,
Could you please have a review for the patch? Thanks.
Attachment #8796447 - Flags: review?(mstange)
Attachment #8796447 - Flags: review?(mstange) → review+
(Assignee)

Comment 3

a year ago
try result: https://treeherder.mozilla.org/#/jobs?repo=try&tochange=d82ca5115d32&fromchange=00e7d5adf5ea19586d650268a32499fa86f1aa0b&selectedJob=28389661

Comment 4

a year ago
Pushed by vliu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1137d7187e52
In nsSVGMaskFrame::GetMaskForMaskedFrame, create surface by Factory::CreateDataSourceSurface. r=mstange

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1137d7187e52
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.