1301459 - In nsSVGMaskFrame::GetMaskForMaskedFrame, create surface by Factory::CreateDataSourceSurface

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[u459114]

In Bug 1301353 comment 3, mstange said:
why are we obtaining the surface by snapshotting an unused DrawTarget? We should create it through Factory::CreateDataSourceSurface.

Comment 1

[Vincent Liu[:vliu]]

I will take this issue for the following.

Comment 2

[Vincent Liu[:vliu]]

Attachment: In nsSVGMaskFrame::GetMaskForMaskedFrame, create surface by Factory::CreateDataSourceSurface.

Hi Markus,
Could you please have a review for the patch? Thanks.

Comment 3

[Vincent Liu[:vliu]]

try result: https://treeherder.mozilla.org/#/jobs?repo=try&tochange=d82ca5115d32&fromchange=00e7d5adf5ea19586d650268a32499fa86f1aa0b&selectedJob=28389661

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1137d7187e52
In nsSVGMaskFrame::GetMaskForMaskedFrame, create surface by Factory::CreateDataSourceSurface. r=mstange

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1137d7187e52