1301611 - Need test cases that changedAnimations is notified to mutation observers when keyframes are changed

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect, P5)

Description

[Hiroyuki Ikezoe (:hiro)]

We have no test cases when we call setKeyframes().

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Set spacing test case in test_animation_observers.html will be a reference.

http://hg.mozilla.org/mozilla-central/file/82d0a583a9a3/dom/animation/test/chrome/test_animation_observers.html#l1970

Comment 2

[gabrielle.singhcadieux]

I'd like to work on this!

Comment 3

[Brian Birtles (:birtles)]

Thanks Gabrielle! Since you fixed bug 1293495, I think you know what to do but please let me (or Boris or Hiro) know if you need help!

Comment 4

[gabrielle.singhcadieux]

Attachment: 1301611.patch

I hope that this test is sufficient! 
It builds and passes.

Comment 5

[Boris Chiou [:boris]]

Comment on attachment 8867796 [details] [diff] [review]
1301611.patch

Review of attachment 8867796 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

::: dom/animation/test/chrome/test_animation_observers_sync.html
@@ +870,5 @@
> +    assert_equals_records(observer.takeRecords(),
> +      [{ added: [], changed: [anim], removed: [] }],
> +      "records after keyframes are set to empty");
> +
> +  }, "setKeyframes");

It seems that we use snake_case in this test file, so it's better to write "set_keyframes".

Comment 6

[gabrielle.singhcadieux]

(In reply to Boris Chiou [:boris] from comment #5)
> Comment on attachment 8867796 [details] [diff] [review]
> 1301611.patch
> 
> Review of attachment 8867796 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> LGTM.
> 
> ::: dom/animation/test/chrome/test_animation_observers_sync.html
> @@ +870,5 @@
> > +    assert_equals_records(observer.takeRecords(),
> > +      [{ added: [], changed: [anim], removed: [] }],
> > +      "records after keyframes are set to empty");
> > +
> > +  }, "setKeyframes");
> 
> It seems that we use snake_case in this test file, so it's better to write
> "set_keyframes".

No problem, I will change that! I was trying to make reference to the use of the `setKeyframes()` function, specifically.

Comment 7

[gabrielle.singhcadieux]

Attachment: 1301611_v2.patch

Comment 8

[Boris Chiou [:boris]]

Comment on attachment 8868354 [details] [diff] [review]
1301611_v2.patch

Review of attachment 8868354 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for updating. LGTM

Comment 9

[Boris Chiou [:boris]]

try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9f0ea2dfc0d68631865bd14b712a7570aca9b20

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a0949cc856f
Test that mutation observer is notified when keyframes are changed using setKeyframes(). r=boris

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2a0949cc856f