1301619 - Update Firefox Android User Agent override for some domains

Status: RESOLVED FIXED

(Web Compatibility :: Interventions, defect)

Description

[Karl Dubost💡 :karlcow]

This is a pool of UA override to remove from 
https://dxr.mozilla.org/mozilla-central/source/mobile/android/app/ua-update.json.in

* auctions.yahoo.co.jp
* news.yahoo.co.jp
* shopping.yahoo.co.jp
* travel.yahoo.co.jp
* sports.yahoo.co.jp
* mixi.jp

Comment 1

[Karl Dubost💡 :karlcow]

fixing a typo for dependency

Comment 2

[Karl Dubost💡 :karlcow]

The typo is here too. Wrong bug number.
https://dxr.mozilla.org/mozilla-central/rev/938ce16be25f9c551c19ef8938e8717ed3d41ff5/mobile/android/app/ua-update.json.in#6

Comment 3

[Mike Taylor [:miketaylr]]

Eric, do you want to take a stab at (a very, very simple...) patch here? I'm happy to review.

Comment 4

[Eric Tsai (no more review request accepted)]

I can help to provide a patch for current China site by this Wednesday.

Comment 5

[Karl Dubost💡 :karlcow]

Eric, this bug is just about the domains in comment #0

> * auctions.yahoo.co.jp
> * news.yahoo.co.jp
> * shopping.yahoo.co.jp
> * travel.yahoo.co.jp
> * sports.yahoo.co.jp
> * mixi.jp

We could add new domains for China but we need to find the relevant bugs first and creates dependencies.

Comment 6

[Eric Tsai (no more review request accepted)]

Thanks Karl, I got the point. Also can do this by this Wednesday. Sorry for misunderstanding.

Comment 7

[Eric Tsai (no more review request accepted)]

Attachment: Patch 1. Update Firefox android User Agent override

Hi Mike, please help to review if this patch works.

Comment 8

[Mike Taylor [:miketaylr]]

Comment on attachment 8790563 [details] [diff] [review]
Patch 1. Update Firefox android User Agent override

Review of attachment 8790563 [details] [diff] [review]:
-----------------------------------------------------------------

looks good, thanks!

r=me

::: mobile/android/app/ua-update.json.in
@@ -3,4 @@
>  // Send these sites a custom user-agent. Bugs should be included with an entry.
>  // NOTE: trailing commas are not valid JSON and will prevent the CDN from syncing.
>  {
> -  // bug 117898, yahoo.co.jp properties

Whoops, good catch.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/c80b283448d3
Update Firefox android User Agent override. r=miket

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c80b283448d3