1301648 - Add a pref to be able to control the AudioCallbackDriver requested latency

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect, P2)

Description

[Paul Adenot (:padenot)]

We have a pref to control the HTMLMediaElement latency, but we don't have a pref to control the MSG latency, for Web Audio API and WebRTC, we should make one. It's going to be very useful to debug.

Comment 1

[Paul Adenot (:padenot)]

Attachment: Bug 1301648 - Add a pref to be able to control the AudioCallbackDriver requested latency.

Review commit: https://reviewboard.mozilla.org/r/77860/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77860/

Comment 2

[Paul Adenot (:padenot)]

Matthew, I decided to keep having the playback latency in milliseconds, but to have the MSG latency in frames, because it's expected to be smaller, and we want to do some testing where we want to set it at very precise values, without having to be careful about rounding when converting between ms and frames, etc.

This also renames a number of variables and functions so that their purpose and unit is clearer, now that we have two somewhat similar prefs.

Comment 3

[Matthew Gregan [:kinetik]]

Comment on attachment 8789780 [details]
Bug 1301648 - Add a pref to be able to control the AudioCallbackDriver requested latency.

https://reviewboard.mozilla.org/r/77860/#review76814

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f5e2940b1f0b
Add a pref to be able to control the AudioCallbackDriver requested latency. r=kinetik

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f5e2940b1f0b

Comment 6

[Gerry Chang [:gchang]]

Mark 51 won't fix as this is new to 51. If it's worth uplifting to 51, feel free to nominate it.