Closed Bug 1301648 Opened 3 years ago Closed 3 years ago

Add a pref to be able to control the AudioCallbackDriver requested latency

Categories

(Core :: Audio/Video: cubeb, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox51 --- wontfix
firefox52 --- fixed

People

(Reporter: padenot, Assigned: padenot)

References

Details

Attachments

(1 file)

We have a pref to control the HTMLMediaElement latency, but we don't have a pref to control the MSG latency, for Web Audio API and WebRTC, we should make one. It's going to be very useful to debug.
Assignee: nobody → padenot
Matthew, I decided to keep having the playback latency in milliseconds, but to have the MSG latency in frames, because it's expected to be smaller, and we want to do some testing where we want to set it at very precise values, without having to be careful about rounding when converting between ms and frames, etc.

This also renames a number of variables and functions so that their purpose and unit is clearer, now that we have two somewhat similar prefs.
Comment on attachment 8789780 [details]
Bug 1301648 - Add a pref to be able to control the AudioCallbackDriver requested latency.

https://reviewboard.mozilla.org/r/77860/#review76814
Attachment #8789780 - Flags: review?(kinetik) → review+
Rank: 23
Priority: -- → P2
See Also: → 1300818
Pushed by paul@paul.cx:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f5e2940b1f0b
Add a pref to be able to control the AudioCallbackDriver requested latency. r=kinetik
https://hg.mozilla.org/mozilla-central/rev/f5e2940b1f0b
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Mark 51 won't fix as this is new to 51. If it's worth uplifting to 51, feel free to nominate it.
You need to log in before you can comment on or make changes to this bug.