Closed Bug 1301649 Opened 3 years ago Closed 3 years ago

nits for firstPartyDomain in bug 1260931

Categories

(Core :: DOM: Security, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: allstars.chh, Assigned: allstars.chh)

References

(Blocks 1 open bug)

Details

(Whiteboard: [tor], [domsecurity-backlog2])

Attachments

(1 file, 2 obsolete files)

Priority: -- → P3
Assignee: nobody → allstars.chh
Attached patch Patch. (obsolete) — Splinter Review
Attached patch Patch. (obsolete) — Splinter Review
Attachment #8797976 - Attachment is obsolete: true
Comment on attachment 8798289 [details] [diff] [review]
Patch.

Ok, looks like this should work inside mozbrowser too.
Attachment #8798289 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/a0f243dead30
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Hi Iris
I found there's an issue in Bug 1310276, however I don't have enough time to fix it in this release,  can you help me to back this out from m-c?

https://hg.mozilla.org/mozilla-central/rev/a0f243dead30

Thanks
Flags: needinfo?(ihsiao)
Duplicate of this bug: 1310276
Backed out in https://hg.mozilla.org/mozilla-central/rev/99a239e1866a
Status: RESOLVED → REOPENED
Flags: needinfo?(ihsiao)
Resolution: FIXED → ---
Target Milestone: mozilla52 → ---
Priority: P3 → P2
Attached patch Patch. v2Splinter Review
Given we had problems when removed the code in HttpBaseChannel.cpp in comment 7, so this time I just updated the code in nsFrameLoader.cpp
Attachment #8798289 - Attachment is obsolete: true
Attachment #8842712 - Flags: review?(bugs)
Attachment #8842712 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/ab115811036d
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.