1301649 - nits for firstPartyDomain in bug 1260931

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P2)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

To address to nits mentioned by Jonas
https://bugzilla.mozilla.org/show_bug.cgi?id=1260931#c121
https://bugzilla.mozilla.org/show_bug.cgi?id=1260931#c124
https://bugzilla.mozilla.org/show_bug.cgi?id=1260931#c130

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cef5c94acea8

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8798289 [details] [diff] [review]
Patch.

Ok, looks like this should work inside mozbrowser too.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a0f243dead30
nits for bug 1260931. r=smaug

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a0f243dead30

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Hi Iris
I found there's an issue in Bug 1310276, however I don't have enough time to fix it in this release,  can you help me to back this out from m-c?

https://hg.mozilla.org/mozilla-central/rev/a0f243dead30

Thanks

Comment 9

[Iris Hsiao [:ihsiao]]

Backed out in https://hg.mozilla.org/mozilla-central/rev/99a239e1866a

Comment 10

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch. v2

Given we had problems when removed the code in HttpBaseChannel.cpp in comment 7, so this time I just updated the code in nsFrameLoader.cpp

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab115811036d
Use MOZ_ASSERT_IF instead. r=smaug

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ab115811036d