Closed
Bug 1301649
Opened 3 years ago
Closed 3 years ago
nits for firstPartyDomain in bug 1260931
Categories
(Core :: DOM: Security, defect, P2)
Core
DOM: Security
P2
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: allstars.chh, Assigned: allstars.chh)
References
(Blocks 1 open bug)
Details
(Whiteboard: [tor], [domsecurity-backlog2])
Attachments
(1 file, 2 obsolete files)
|
1.63 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
To address to nits mentioned by Jonas https://bugzilla.mozilla.org/show_bug.cgi?id=1260931#c121 https://bugzilla.mozilla.org/show_bug.cgi?id=1260931#c124 https://bugzilla.mozilla.org/show_bug.cgi?id=1260931#c130
|
||
Updated•3 years ago
|
Blocks: FirstPartyIsolation
Priority: -- → P3
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → allstars.chh
|
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cef5c94acea8
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•3 years ago
|
||
Attachment #8797976 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•3 years ago
|
Attachment #8798289 -
Flags: review?(bugs)
|
||
Comment 4•3 years ago
|
||
Comment on attachment 8798289 [details] [diff] [review] Patch. Ok, looks like this should work inside mozbrowser too.
Attachment #8798289 -
Flags: review?(bugs) → review+
Pushed by yhuang@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a0f243dead30 nits for bug 1260931. r=smaug
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a0f243dead30
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
|
|
Assignee | |
Comment 7•3 years ago
|
||
Hi Iris I found there's an issue in Bug 1310276, however I don't have enough time to fix it in this release, can you help me to back this out from m-c? https://hg.mozilla.org/mozilla-central/rev/a0f243dead30 Thanks
Flags: needinfo?(ihsiao)
|
||
Comment 9•3 years ago
|
||
Backed out in https://hg.mozilla.org/mozilla-central/rev/99a239e1866a
Status: RESOLVED → REOPENED
Flags: needinfo?(ihsiao)
Resolution: FIXED → ---
|
|
||
Updated•3 years ago
|
status-firefox52:
fixed → ---
|
|
||
Updated•3 years ago
|
Target Milestone: mozilla52 → ---
|
|
Assignee | |
Comment 10•3 years ago
|
||
Given we had problems when removed the code in HttpBaseChannel.cpp in comment 7, so this time I just updated the code in nsFrameLoader.cpp
Attachment #8798289 -
Attachment is obsolete: true
Attachment #8842712 -
Flags: review?(bugs)
|
|
||
Updated•3 years ago
|
Attachment #8842712 -
Flags: review?(bugs) → review+
|
||
Comment 11•3 years ago
|
||
Pushed by yhuang@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ab115811036d Use MOZ_ASSERT_IF instead. r=smaug
|
||
Comment 12•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ab115811036d
Status: REOPENED → RESOLVED
Closed: 3 years ago → 3 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•