1301692 - deleting a disabled property leaves a trace in the style editor

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P3)

Description

[Tom Tromey :tromey]

I noticed this while working on bug 1301078.
STR:

Open rule view.
Add a new commented-out property, e.g. by pasting in "/* background: yellow; */".
Now select the property name, clear it, type enter -- this deletes the property.
Switch to style editor.

I see:

  #testid {
    font-size: 4em;
    /*!  */
  }

The editing has left the mostly-empty comment behind.

I think this is just a small oversight in RuleRewriter.removeProperty.

Comment 1

[Patrick Brosset <:pbro>]

Inspector bug triage (filter on CLIMBING SHOES).

Comment 2

[Tom Tromey :tromey]

Attachment: Bug 1301692 - remove comment when deleting disabled property;

Review commit: https://reviewboard.mozilla.org/r/80142/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80142/

Comment 3

[Patrick Brosset <:pbro>]

Comment on attachment 8793390 [details]
Bug 1301692 - remove comment when deleting disabled property;

https://reviewboard.mozilla.org/r/80142/#review79200

Works well, and looks good.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f41d2e492db
remove comment when deleting disabled property; r=pbro

Comment 5

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/3f41d2e492db