Closed Bug 1301719 Opened 8 years ago Closed 8 years ago

Fix new debugger in remote toolboxes

Categories

(DevTools :: Debugger, defect, P1)

Product:
DevTools
Component:
Debugger
Type:
defect

Tracking

(firefox51 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 51
Tracking Flags:
Tracking Status
firefox51 --- fixed

People

(Reporter: jlong, Assigned: jlast)

References

Details

Attachments

(1 file)

fix-panel.patch
930 bytes, patch
jlong
: review+
Details | Diff | Splinter Review 
There is a typo in the new debugger's panel.js. Switching `promise` to `Promise` in the code that checks to see if it's a remote panel should fix the browser toolbox for the most part.
Blocks: 1294139
Attached patch fix-panel.patch — — Splinter Review 

        Attachment #8789846 -
        Flags: review?(jlong)

    
  
Assignee: nobody → jlaster

    
  
Priority: -- → P1

    
    

    
  
We actually don't need a full try run for these changes because they are only in the new debugger which isn't running tests yet

    
    

    
  
Several small things going on so I'm going to go ahead and push this so we make sure this lands.

    
    

    
  
Pushed by jlong@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/184ffdb1a3ac
Fix new debugger in remote toolboxes. r=jlongster

    
  

        Attachment #8789846 -
        Flags: review?(jlong) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/184ffdb1a3ac
Status: NEW → RESOLVED
Closed: 8 years ago

          status-firefox51:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: