1301723 - Add automated tests for unsubmitted crash reports notification

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

+++ This bug was initially created as a clone of Bug #1287178 +++

Spinning this out from bug 1287178. This notification shows up soon after start-up if the user has unsubmitted crash reports in their queue.

We need automated tests for this stuff.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1301723 - Add automated tests for the unsubmitted crash report notification.

Review commit: https://reviewboard.mozilla.org/r/78262/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/78262/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Hey felipe,

I promise I won't make you review all of these pending crash report notification bugs. I'll start spreading it out a bit more for the rest of the follow-up bugs!

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8790470 [details]
Bug 1301723 - Add automated tests for the unsubmitted crash report notification.

https://reviewboard.mozilla.org/r/78262/#review76832

Comment 4

[:Felipe Gomes (needinfo for replies!)]

(In reply to Mike Conley (:mconley) - (Digging through needinfos and reviews) from comment #2)
> Hey felipe,
> 
> I promise I won't make you review all of these pending crash report
> notification bugs. I'll start spreading it out a bit more for the rest of
> the follow-up bugs!

Hey, no worries. Keep 'em coming!  Also, I may or may not have some patches for you to review soon.. ;)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33de74be048e
Add automated tests for the unsubmitted crash report notification. r=Felipe

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6949e171dfd4
Follow up: disable browser_UnsubmittedCrashHandler.js test if crash reporter not available. r=test-only

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Attachment: Disable test if crashreporter not available

Whoops - looks like I broke ASAN builds. Again. I need to remember that crash reporter isn't available for all builds!

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8791324 [details] [diff] [review]
Disable test if crashreporter not available

(And this patch was pushed in by KWierso in comment 6)

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/33de74be048e
https://hg.mozilla.org/mozilla-central/rev/6949e171dfd4