1301803 - MOZ_CRASH("GFX: Bad `elemType`.") in mozilla::WebGLActiveInfo::WebGLActiveInfo

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P3)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

This bug was filed from the Socorro interface and is 
report bp-466aceb6-b036-4e22-9932-1d8ae2160909.
=============================================================

Low volume crash that started with the 9-08 Fennec nightly (regression range [1]). So far, there have been 5 crashes for that nightly, making it the #3 crash for Fennec. One noticeable thing about the crashes is that they all come from x86 builds, which is uncommon for Fennec.

Jeff, any idea what could be the cause? Maybe bug 1297924?

[1] https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=91c2b9d5c1354ca79e5b174591dbb03b32b15bbf&tochange=938ce16be25f9c551c19ef8938e8717ed3d41ff5

Comment 1

[Ethan Lin[:ethlin]]

(In reply to Jim Chen [:jchen] [:darchons] from comment #0)
> This bug was filed from the Socorro interface and is 
> report bp-466aceb6-b036-4e22-9932-1d8ae2160909.
> =============================================================
> 
> Low volume crash that started with the 9-08 Fennec nightly (regression range
> [1]). So far, there have been 5 crashes for that nightly, making it the #3
> crash for Fennec. One noticeable thing about the crashes is that they all
> come from x86 builds, which is uncommon for Fennec.
> 
> Jeff, any idea what could be the cause? Maybe bug 1297924?
> 
> [1]
> https://hg.mozilla.org/mozilla-central/
> pushloghtml?fromchange=91c2b9d5c1354ca79e5b174591dbb03b32b15bbf&tochange=938c
> e16be25f9c551c19ef8938e8717ed3d41ff5

The pushlog also contains the backout commits of bug 1297924. So I think bug 1297924 isn't related.

Comment 2

[Ethan Lin[:ethlin]]

Attachment: add note

I think the crash means we got error in glGetActiveAttrib. The 'elemType' should be zero. I add gfxCriticalNote to log the glError for more debug information.

Comment 3

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8790591 [details] [diff] [review]
add note

Review of attachment 8790591 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/WebGLProgram.cpp
@@ +176,5 @@
>          gl->fGetActiveAttrib(prog->mGLName, i, mappedName.Length()+1, &lengthWithoutNull,
>                               &elemCount, &elemType, mappedName.BeginWriting());
> +        GLenum error = gl->fGetError();
> +        if (error != LOCAL_GL_NO_ERROR)
> +            gfxCriticalNote << "Failed to do glGetActiveAttrib: " << error;

{} this line, since it's not a control flow statement.

Comment 4

[Ethan Lin[:ethlin]]

(In reply to Jeff Gilbert [:jgilbert] from comment #3)
> Comment on attachment 8790591 [details] [diff] [review]
> add note
> 
> Review of attachment 8790591 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/canvas/WebGLProgram.cpp
> @@ +176,5 @@
> >          gl->fGetActiveAttrib(prog->mGLName, i, mappedName.Length()+1, &lengthWithoutNull,
> >                               &elemCount, &elemType, mappedName.BeginWriting());
> > +        GLenum error = gl->fGetError();
> > +        if (error != LOCAL_GL_NO_ERROR)
> > +            gfxCriticalNote << "Failed to do glGetActiveAttrib: " << error;
> 
> {} this line, since it's not a control flow statement.

Okay.

Comment 5

[Ethan Lin[:ethlin]]

Attachment: add note (carry r+: jgilbert)

Address jgilbert's comments.

Comment 6

[Ethan Lin[:ethlin]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba9c8ee19461&selectedJob=27439033

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b01b2c0df5d
Add gfxCriticalNote for glGetActiveAttrib. r=jgilbert

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2b01b2c0df5d

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The leave-open keyword is there and there is no activity for 6 months.
:jgilbert, maybe it's time to close this bug?

Comment 10

[Kelsey Gilbert [:jgilbert]]

https://crash-stats.mozilla.com/report/index/a7a088f8-bc12-440e-ba7d-e63530181112#tab-metadata

GraphicsCriticalError:
|[0][GFX1-]: Failed to do glGetActiveAttrib: 1287 (t=144.409) |[1][GFX1-]: Failed to do glGetActiveAttrib: 1287 (t=144.409) 

> #define GL_CONTEXT_LOST                   0x0507

That makes sense!

This will get easier after bug 1492580.

Comment 11

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1301803 - Handle context loss during QueryProgramInfo.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd7547ae0876
Handle context loss during QueryProgramInfo. r=lsalzman

Comment 13

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/cd7547ae0876

Comment 14

[Kelsey Gilbert [:jgilbert]]

I'm fairly confident that's it for now.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Is this something that should get a Beta approval request or can it ride the trains?

Comment 16

[Kelsey Gilbert [:jgilbert]]

Based on the crash volumes, I say ride the trains.