1301821 - NSPR_LOG_MODULES deprecation warning needs clarification

Status: NEW

(Core :: XPCOM, defect, P3)

Description

[Nico Grunbaum [:ng, @chew:mozilla.org]]

The implication of the current warning:
  WARNING: NSPR_LOG_MODULES is deprecated.
  Please use MOZ_LOG instead.

is that the use of NSPR_LOG_MODULES can be replaced with MOZ_LOG, which it can't for modules that still use old logging backend.

Comment 1

[Eric Rahm [:erahm]]

Maybe something like "Note: NSPR_LOG_MODULES is intended to be used to enable NSPR and NSS logs, use MOZ_LOG for gecko logs" would be more clear.

Comment 2

[Nico Grunbaum [:ng, @chew:mozilla.org]]

That would work for me.

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

One big annoyance is that there's no way to know which logs work with which, so the only "safe" thing to do is to always set NSPR_LOG_MODULES (only).  

There are several that are still using PR_NewLogModule() that probably don't have to be -- GMP (probably), AudioChannel, nsUpdateDriver probably, NSS perhaps, widget/gtk (several), Clipboard, nsSound, idleService, WinWakeLock