1301874 - Unable to maximise videos on liveleak.com (Firefox mobile)

Status: RESOLVED FIXED

(Web Compatibility :: Mobile, defect, P3)

Description

[bug.zilla]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20160903004009

Steps to reproduce:

Visit liveleak.com and attempt to maximise a video


Actual results:

Video does not maximise


Expected results:

Video should maximise

Comment 1

[Blake Wu [:bwu][:blakewu]]

Ray, 
Can you help have a look?

Comment 2

[Blake Wu [:bwu][:blakewu]]

BTW,I can see this problem on my nightly.

Comment 3

[Ray Lin[:ralin]]

liveleak.com uses jwplayer v6.8. To trace the behavior back to version 6.8 (about 2.5 years ago), I found these lines of code [0]. For android, it should run into _isMobile block, however, it does something make no sense for Fennec(all version) to toggle fullscreen. In other hand, it was doing right on webkit based browser(see line: 373). 

It seems the only way is to try to ask liveleak.com upgrade jwplayer's version, otherwise we could not help with this issue.  
By the way, [1] is the latest fullscreen implementation of jwplayer, it should work fine.

[0] https://github.com/jwplayer/jwplayer/blob/v6.8.0/src/js/html5/jwplayer.html5.view.js#L361-L392
[1] https://github.com/jwplayer/jwplayer/blob/15fe00794cfbbef6e2d63c0c6023e82be4151ca9/src/js/view/view.js#L102-L107

Comment 4

[Blake Wu [:bwu][:blakewu]]

Ray, 
Thanks for your super fast check!
I will try to talk to liveleak to see if they can upgrade their JW player.

Comment 5

[Anthony Jones (:ajones, :kentuckyfriedtakahe, :k17e)]

Mike - if we make this tech evangelism, will someone try to contact the site?

Comment 6

[Karl Dubost💡 :karlcow]

This issue is a duplicate of https://webcompat.com/issues/551
I tried to contact them a couple of times. My latest attempt was 21 days ago, where I had a human replying to me. I sent a message.

Comment 7

[Mike Taylor [:miketaylr]]

Thanks Karl!

Comment 8

[Mike Taylor [:miketaylr]]

This seems to be fixed now -- fullscreen button works as expected.