Open Bug 1301884 Opened 8 years ago Updated 8 years ago

Bugzilla needs to use JSON::MaybeXS

Categories

(Bugzilla :: Bugzilla-General, defect)

Product:
Bugzilla
Component:
Bugzilla-General
Version:
5.1.1
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Milestone:
Bugzilla 6.0

People

(Reporter: dylan, Assigned: dylanAtHome)

Details

Attachments

(1 file)

[bugzilla] dylanwh:bug-1301884 > bugzilla:master
44 bytes, text/x-github-pull-request
jfearn
: review+
Details | Review
perl -T rest.cgi in a fresh bugzilla install will fail because JSON cannot be loaded
Attachment #8790033 - Flags: review?(dkl)
Comment on attachment 8790033 [details] [review] [bugzilla] dylanwh:bug-1301884 > bugzilla:master See comment in pull request.
Attachment #8790033 - Flags: review?(dkl) → review-
Summary: Bugzilla uses JSON but specifies dependency on JSON::XS → Bugzilla needs to use JSON::MaybeXS
Target Milestone: --- → Bugzilla 6.0
Attachment #8790033 - Flags: review-
Assignee: dylan → dylan
Comment on attachment 8790033 [details] [review] [bugzilla] dylanwh:bug-1301884 > bugzilla:master Since you reviewed the previous version of this. I realize you'll be trying to clear your review queue so feel free to unset review? if it's a problem. JSON::MaybeXS exports a JSON constant, so we can do JSON->true, JSON->false, and even JSON->new(). It also exports encode_json and decode_json.
Attachment #8790033 - Flags: review?(dkl)
Comment on attachment 8790033 [details] [review] [bugzilla] dylanwh:bug-1301884 > bugzilla:master Comments in GH PR.
Attachment #8790033 - Flags: review?(dkl) → review-
Comment on attachment 8790033 [details] [review] [bugzilla] dylanwh:bug-1301884 > bugzilla:master With changes from PR comments.
Attachment #8790033 - Flags: review- → review?(dkl)
Attachment #8790033 - Flags: review?(dkl) → review?(jfearn)
Attachment #8790033 - Flags: review?(jfearn) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: