1301906 - Broken HTML in lower left panel for "fixed by commit" jobs

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Phil Ringnalda (:philor)]

Annotate a job as "fixed by commit" with a cset hash in the comment like https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=baaf5f5624d32358ba3a1464dc5c5b3333103116&selectedJob=35653965&filter-searchStr=973ecc90181425aed86d7fc88cb084b24101ef55 and in the lower left panel you get some sort of broken HTML that results in a link to "https://treeherder.mozilla.org/%3Ca%20href=" with the link text "https://hg.mozilla.org/integration/mozilla-inbound/rev/43725e6c61b3" and stray text that was intended to be the link text of "">43725e6c61b3" after the link.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] KWierso:1301906 > mozilla:master

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8790056 [details] [review]
[treeherder] KWierso:1301906 > mozilla:master

Should be a quick review, the filter was actually working correctly, but angular (or something between when angular gets back the filtered string and it getting injected into the page's html) was choking on the quotes within the html string. This patch got things rendering correctly locally just now.

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/ff10e7bd15cbc62402b9d63b3b5bca483f8094bd
Bug 1301906 - Make sure linkifyClassifications filter gives proper results (#1843) r=camd