1301941 - Dimmed highlighting mode: Deleting last character does not remove dimming

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Albert Scheiner [:alberts]]

Attachment: bug1291278-related.ogv

After searching for "slow down" on the linked page & removing the search term from the search input field character by character removing the last (first) "s" does not cancel the dimming as expected - the "s" in the page is even still highlighted.
see the last few seconds in the video attached

Comment 1

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1301941 - hide the dimmed modal highlight of the find toolbar when the last character is removed from the input field.

Review commit: https://reviewboard.mozilla.org/r/79182/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79182/

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8791899 [details]
Bug 1301941 - hide the dimmed modal highlight of the find toolbar when the last character is removed from the input field.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/79182/diff/1-2/

Comment 3

[Mike de Boer [:mikedeboer]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=916b12aee377

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8791899 [details]
Bug 1301941 - hide the dimmed modal highlight of the find toolbar when the last character is removed from the input field.

https://reviewboard.mozilla.org/r/79182/#review78132

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00897f5b0db1
hide the dimmed modal highlight of the find toolbar when the last character is removed from the input field. r=jaws

Comment 7

[Milan Sreckovic [:milan] (needinfo for best results)]

I see the problem in 50 as well.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/00897f5b0db1

Comment 9

[roxleitan]

Verified as fixed on Windows 10 and Windows 7 on the latest Nightly 52.0a1 Build ID: 20160920030429

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Mike, same here: as this is marked as impacting 50 (maybe it has been disabled), do you want to uplift that? 
If yes, could you fill the uplift request? Thanks

Comment 12

[Mike de Boer [:mikedeboer]]

Comment on attachment 8791899 [details]
Bug 1301941 - hide the dimmed modal highlight of the find toolbar when the last character is removed from the input field.

Approval Request Comment
[Feature/regressing bug #]: bug 384458 and dependencies
[User impact if declined]: When removing the last character from the findbar input box, the highlights will not disappear.
[Describe test coverage new/current, TreeHerder]: landed on trunk, now on 52, tests added and all pass.
[Risks and why]: minor, specific regression fix.
[String/UUID change made/needed]: n/a.

Comment 14

[Mike de Boer [:mikedeboer]]

Comment on attachment 8791899 [details]
Bug 1301941 - hide the dimmed modal highlight of the find toolbar when the last character is removed from the input field.

Nope, this patch will not do it entirely. Please see bug 1316515 for more details.

Comment 15

[Liz Henry (:lizzard) (relman/hg->git project)]

OK, looks like this is fixed in bug 1316515 for 51 and up, now. Thanks Mike!

Comment 16

[roxleitan]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20161124073320

Verified as fixed using the STR from Description and STR from Bug 1315428(DUPLICATE of bug 1301941)on the latest Firefox Beta 51.0b3 (having preferences findbar.modalHighlight and findbar.highlightAll true and false) on Windows 10 x64, Ubuntu 15.10 and Mac OS X 10.11. 

Setting status-firefox51 to verified.