Allow passing an empty Endpoint<> over IPDL

RESOLVED FIXED in Firefox 52

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mattwoodrow, Assigned: dvander)

Tracking

Trunk
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 fix-optional, firefox52 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

3 years ago
For VideoDecoding, we want to fail the initialization if there isn't a GPU process.

The simplest way to do this is to allow returning an empty Endpoint<> from the parent process when we couldn't connect to the GPU process.
Reporter

Updated

3 years ago
Assignee: nobody → dvander
Posted patch patch (obsolete) — Splinter Review
Shortcut on reading/writing invalid Endpoints, instead of using MOZ_RELEASE_ASSERT. We still release assert when binding an invalid Endpoint though. This will let us handle failures easier.
Attachment #8790588 - Flags: review?(wmccloskey)
Reporter

Comment 2

3 years ago
Comment on attachment 8790588 [details] [diff] [review]
patch

Review of attachment 8790588 [details] [diff] [review]:
-----------------------------------------------------------------

I think we need a public IsValid() function added to Endpoint, since mValid is private.
Posted patch patchSplinter Review
Whoops, you're right.
Attachment #8790588 - Attachment is obsolete: true
Attachment #8790588 - Flags: review?(wmccloskey)
Attachment #8790853 - Flags: review?(wmccloskey)
Status: NEW → ASSIGNED
Attachment #8790853 - Flags: review?(wmccloskey) → review+

Comment 4

3 years ago
Pushed by danderson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ee6bf23101a
Allow passing an empty Endpoint over IPDL. (bug 1302009, r=billm)

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4ee6bf23101a
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Reporter

Updated

3 years ago
Blocks: 1305320
Mark 51 as fix-optional. If it's worth uplift to 51, feel free to nominate it.
You need to log in before you can comment on or make changes to this bug.