Closed Bug 1302087 Opened 3 years ago Closed 3 years ago

[Static Analysis][Missing break in switch] In function OutputTextureFunctionArgumentList

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
firefox51 --- affected

People

(Reporter: andi, Assigned: andi)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: CID 1372809)

Attachments

(1 obsolete file)

The Static Analysis tool Coverity detected that a break in switch is missing causing it to fall on the default branch:

>>            case EbtSampler2DShadow:
>>                out << ", int2 offset";
>>                break;
>>            case EbtSampler2DArrayShadow:
>>                out << ", int2 offset";
>>                break;
>>            case EbtSamplerExternalOES:
>>                out << ", int2 offset";
>>            default:
>>                UNREACHABLE();

I think that on case EbtSamplerExternalOES we should break the execution and we can also compact the switch statement a bit more.
Comment on attachment 8790256 [details]
Bug 1302087 - prevent fallback on default branch for case EbtSamplerCubeShadow.

https://reviewboard.mozilla.org/r/78164/#review76652

This is a third-party project. So we should just fix it there.
Attachment #8790256 - Flags: review?(jmuizelaar) → review-
Morris, can you get this fixed in upstream ANGLE?
Flags: needinfo?(mtseng)
Hope this gets approved: https://github.com/google/angle/pull/4
I've pushed it on github to Angle repo.
Flags: needinfo?(mtseng)
This patch has also been submitted to google chromium reviewboard and has been accepted:

https://chromium-review.googlesource.com/#/c/390271/
Attachment #8790256 - Attachment is obsolete: true
I think this should be closed since the patch has landed upstream.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.