1302087 - [Static Analysis][Missing break in switch] In function OutputTextureFunctionArgumentList

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity detected that a break in switch is missing causing it to fall on the default branch:

>>            case EbtSampler2DShadow:
>>                out << ", int2 offset";
>>                break;
>>            case EbtSampler2DArrayShadow:
>>                out << ", int2 offset";
>>                break;
>>            case EbtSamplerExternalOES:
>>                out << ", int2 offset";
>>            default:
>>                UNREACHABLE();

I think that on case EbtSamplerExternalOES we should break the execution and we can also compact the switch statement a bit more.

Comment 1

[Andi [:andi]]

Attachment: Bug 1302087 - prevent fallback on default branch for case EbtSamplerCubeShadow.

Review commit: https://reviewboard.mozilla.org/r/78164/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/78164/

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8790256 [details]
Bug 1302087 - prevent fallback on default branch for case EbtSamplerCubeShadow.

https://reviewboard.mozilla.org/r/78164/#review76652

This is a third-party project. So we should just fix it there.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Morris, can you get this fixed in upstream ANGLE?

Comment 4

[Andi [:andi]]

Hope this gets approved: https://github.com/google/angle/pull/4
I've pushed it on github to Angle repo.

Comment 5

[Andi [:andi]]

This patch has also been submitted to google chromium reviewboard and has been accepted:

https://chromium-review.googlesource.com/#/c/390271/

Comment 6

[Andi [:andi]]

I think this should be closed since the patch has landed upstream.