Closed
Bug 1302352
Opened 9 years ago
Closed 9 years ago
browser_context_menu_iframe.js is skipped in e10s
Categories
(Toolkit :: Password Manager, defect)
Toolkit
Password Manager
Tracking
()
RESOLVED
FIXED
mozilla51
People
(Reporter: evanxd, Assigned: evanxd)
Details
Attachments
(1 file)
1.10 KB,
patch
|
MattN
:
review+
|
Details | Diff | Splinter Review |
The "browser_context_menu_iframe.js" test is skiped[1] on e10s environment. Let's re-enable it.
[1]: http://searchfox.org/mozilla-central/source/toolkit/components/passwordmgr/test/browser/browser.ini#56-57
Assignee | ||
Comment 1•9 years ago
|
||
Pushed a new try[1]: Re-enable the test to debug.
[1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=513287064996
Updated•9 years ago
|
tracking-e10s:
--- → ?
Assignee | ||
Comment 2•9 years ago
|
||
Re-trigger "browser_context_menu_iframe.js" test for multiple times to reproduce the intermittent failure.
Assignee | ||
Comment 3•9 years ago
|
||
The "browser_context_menu_iframe.js" test is passed for 50 times continuously. Looks like we can re-enable it.
Assignee | ||
Comment 4•9 years ago
|
||
Hi Matthew,
Let's re-enable the test. It is passed for 50 times continuously on the try[1].
Thanks for the review.
[1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=513287064996
Attachment #8791086 -
Flags: review?(MattN+bmo)
Assignee | ||
Comment 5•9 years ago
|
||
Pushed a try[1] for updating commit message.
[1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d8b29a4285b6
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → evan
![]() |
||
Updated•9 years ago
|
Updated•9 years ago
|
Status: NEW → ASSIGNED
Comment 6•9 years ago
|
||
I think it was just skipped because it was assumed that it should be since it was copied from browser_context_menu.js (which is disabled in e10s).
Summary: Intermittent e10s browser_context_menu_iframe.js → browser_context_menu_iframe.js is skipped in e10s
Updated•9 years ago
|
Attachment #8791086 -
Flags: review?(MattN+bmo) → review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fda5c90a13da
Re-enable browser_context_menu_iframe.js in e10s environment. r=MattN
Keywords: checkin-needed
Comment 9•9 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•