Closed Bug 1302379 Opened 4 years ago Closed 3 months ago

Remove MediaStream.active hack for mozCaptureStream with media sources

Categories

(Core :: Audio/Video: MediaStreamGraph, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla72
Tracking Status
firefox72 --- fixed

People

(Reporter: pehrsons, Assigned: pehrsons)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

Bug 1208316 landed with a hack to when we make MediaStreams go inactive when they originate from HTMLMediaElement.mozCaptureStream where the media element is playing a non-MediaStream source.

Because such a mozCaptureStream MediaStream recreates all its tracks on seek (bug 1172394) it would cause a HTMLMediaElement playing the stream to end unintentionally - bug 1208316 was partially about making this change to HTMLMediaElement.

When bug 1172394 gets fixed we should remove this hack.
Rank: 35
Priority: -- → P3
Mass change P3->P4 to align with new Mozilla triage process.
Priority: P3 → P4
Assignee: nobody → apehrson
Blocks: 1423241
Status: NEW → ASSIGNED
Rank: 35 → 13
Priority: P4 → P2
I will work around this in bug 1423241 instead.

This cannot really happen until we deal with bug 1172394 as it seems.
Assignee: apehrson → nobody
No longer blocks: 1423241
Status: ASSIGNED → NEW
Rank: 13 → 25
Priority: P2 → P3
No longer blocks: 1172394
Depends on: 1172394
Assignee: nobody → apehrson
Status: NEW → ASSIGNED

It is no longer needed with captured tracks' lifetimes spanning across seek
operations.

Depends on D52050

Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/306341d0b586
Remove FinishedOnInactive hack from DOMMediaStream. r=jib

Backed out for failures on browser_disabledForMediaStreamVideos.js see Bug 1172394

Pushed by pehrsons@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4b0c0545d300
Remove FinishedOnInactive hack from DOMMediaStream. r=jib
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72
You need to log in before you can comment on or make changes to this bug.