1302461 - Handle changes to details of mozbrowserlocationchange events

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[asppsa]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160824215626

Steps to reproduce:

According to my testing the "mozbrowserlocationchange" event as described at https://developer.mozilla.org/en-US/docs/Web/Events/mozbrowserlocationchange has been changed in recent Gecko versions to match the "Servo only" version in that document.

There are a smattering of places in the Gaia codebase where at present a URL is being looked for in the "details" attribute of mozbrowserlocationchange.  These will need to be changed to "details.url", assuming this is a permanent change to Gecko.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] asppsa:bug-1302461 > mozilla-b2g:master

Comment 2

[asppsa]

Attachment: PR#34420 - Handle changes to mozbrowserlocationchange events

Here's a proposed fix for the only instance I found in the system app of where this was a problem.

Comment 3

[asppsa]

I've not actually checked to see if the change to mozbrowserlocationchange was intentional or not ...

Comment 4

[Myk Melez [:myk] [@mykmelez]]

(In reply to asppsa from comment #3)
> I've not actually checked to see if the change to mozbrowserlocationchange
> was intentional or not ...

It's definitely intentional!  As Fabrice has noted by his reference to bug 1279635.  Sorry about the bustage. :-/

Comment 5

[[:fabrice] Fabrice Desré]

https://github.com/mozilla-b2g/gaia/commit/9dbb956488c7ea5935aefc25acea957881e19cac