1302534 - On Bugzilla attachment pages, findbar "dimmed highlighting mode" moves matches outside of scrollable region & grows the page height

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Visit https://bugzilla.mozilla.org/attachment.cgi?id=8790104&action=edit
 2. Open findbar (Ctrl+F on Linux)
 3. Type in "newline"
 4. Hit Ctrl+G (or downarrow on findbar) a few times to cycle through the matches.

EXPECTED RESULTS:
The scrollable area should be scrolled to the first instance of the word "newline", and it should be highlighted.  (And then the next instance, etc.)

ACTUAL RESULTS:
 * The highlighted version of "newline" is floating awkwardly near the bottom of the page, outside the scrollable area.
 * As I progress through the matches, the page's height grows quite a bit for some reason (which suggests we're throwing content down offscreen, perhaps). You can see this on Linux by noticing that the page's main scrollbar changes size -- and indeed, you can scroll and see there's a lot of blank space at the bottom of the page now.   This blank space sticks around after you close the findbar, even.

I'm using Nightly 51.0a1 (2016-09-13) (64-bit) on Ubuntu Linux 16.04.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot #1 (showing "newline" highlight floating way out of place for some reason)

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screenshot #2 (showing page being super-tall after performing find-in-page operation)

Comment 4

[Gerry Chang [:gchang]]

This feature will be disabled in 51.

Comment 6

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1302534 - track ranges inside elements that have overflow set to 'auto' or 'scroll' and make sure they repaint each time it's scrolled on the dimmed highlighting layer.

Review commit: https://reviewboard.mozilla.org/r/80728/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80728/

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8794171 [details]
Bug 1302534 - track ranges inside elements that have overflow set to 'auto' or 'scroll' and make sure they repaint each time it's scrolled on the dimmed highlighting layer.

https://reviewboard.mozilla.org/r/80728/#review79396

We should be introducing new automated tests to make sure this doesn't break in the future.

::: toolkit/modules/FinderHighlighter.jsm:755
(Diff revision 1)
>     * is the case for 'fixed' and 'sticky' positioned elements and elements inside
>     * (i)frames.
>     *
>     * @param  {nsIDOMRange} range Range that be enclosed in a dynamic container
>     * @return {Boolean}
>     */
>    _isInDynamicContainer(range) {
> -    const kFixed = new Set(["fixed", "sticky"]);
> +    const kFixed = new Set(["fixed", "sticky", "scroll", "auto"]);

This comment needs to be updated.

Comment 8

[Mike de Boer [:mikedeboer]]

Comment on attachment 8794171 [details]
Bug 1302534 - track ranges inside elements that have overflow set to 'auto' or 'scroll' and make sure they repaint each time it's scrolled on the dimmed highlighting layer.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/80728/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8bdb7123498
track ranges inside elements that have overflow set to 'auto' or 'scroll' and make sure they repaint each time it's scrolled on the dimmed highlighting layer. r=jaws

Comment 10

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/a8bdb7123498

Comment 12

[roxleitan]

Verified fixed using the latest Nightly 52.0a1 (Build ID: 20161109030210) on Windows 10, Ubuntu 16.04 and Mac OS X 10.12.