1302658 - [Static Analysis][Dereference before null check] In functions nsScriptLoader::ProcessScriptElement and nsScriptLoader::StartLoad

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity detected that there are several place where dereference before null check appears:

>>  // If this document is sandboxed without 'allow-scripts', abort.
>>  if (mDocument->HasScriptsBlockedBySandbox()) {
>>    return NS_OK;
>>  } 

and 

>>  // Check to see if scripts has been turned off.
>>  if (!mEnabled || !mDocument->IsScriptEnabled()) {
>>    return false;
>>  }

I think it is safe to guard the usage with NS_ENSURE_TRUE

Comment 1

[Andi [:andi]]

Attachment: Bug 1302658 - substitute null checks with NS_ENSURE_TRUE.

Review commit: https://reviewboard.mozilla.org/r/78642/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/78642/

Comment 2

[Andrea Marchesini [:baku]]

Comment on attachment 8791092 [details]
Bug 1302658 - substitute null checks with NS_ENSURE_TRUE.

https://reviewboard.mozilla.org/r/78642/#review77224

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd37ea2f83d3
substitute null checks with NS_ENSURE_TRUE. r=baku

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bd37ea2f83d3