1302679 - Remove obsolete entries from browser/filter.py and l10n.ini

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Francesco Lodolo [:flod]]

We should remove extensions/reporter from both files
http://hg.mozilla.org/mozilla-central/file/tip/browser/locales/filter.py#l15
http://hg.mozilla.org/mozilla-central/file/default/browser/locales/l10n.ini#l11

And make sure l10n repos don't have that folder anymore.

We might need to clean up pocket too, if that doesn't land in bug 1301442

Comment 1

[Francesco Lodolo [:flod]]

Double checked repos, and the only locales I've found with extensions/reporter are unsupported locales: nr, rw, ss, st, ts.

Comment 2

[Francesco Lodolo [:flod]]

Fixed pocket for es-AR and sl on l10n-central.

Fixed extensions/reporter also for obsolete locales across branches: nr, rw, ss, st, ts.

Comment 3

[Francesco Lodolo [:flod]]

Attachment: bug1302679.patch

Comment 4

[Francesco Lodolo [:flod]]

Comment on attachment 8799303 [details] [diff] [review]
bug1302679.patch

Review of attachment 8799303 [details] [diff] [review]:
-----------------------------------------------------------------

Clearing r? for now, the patch doesn't seem to work as I'd expect.

Comment 5

[Francesco Lodolo [:flod]]

Comment on attachment 8799303 [details] [diff] [review]
bug1302679.patch

Review of attachment 8799303 [details] [diff] [review]:
-----------------------------------------------------------------

OK, I think I've figured out why a file in browser/extensions/pocket is still reported as obsolete with this patch applied: it's still analyzed as part of mod="browser"

Comment 6

[Axel Hecht [:Pike]]

Comment on attachment 8799303 [details] [diff] [review]
bug1302679.patch

Review of attachment 8799303 [details] [diff] [review]:
-----------------------------------------------------------------

right, but then against browser/locales/en-US/extensions/pocket. Which doesn't exist either, so this is cool.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8c51fc68856e
Remove extensions/reporter and browser/extensions/pocket from compare-locales checks. r=pike

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/8c51fc68856e