1302705 - Deprecate SVGSVGElement.deselectAll()

Status: RESOLVED FIXED

(Core :: SVG, task, P3)

Description

[Sebastian Zartner [:sebo]]

SVG 2 deprecated the SVGSVGElement.deselectAll() method[1], because it duplicates functionality of the Selection API.

To let web developers know about the deprecation, a console warning should be output when the method is used.

Sebastian

[1] https://svgwg.org/svg2-draft/changes.html#structure

Comment 1

[Robert Longson [:longsonr]]

Attachment: Bug 1302705 - Add console warning about SVGSVGElement.deselectAll() being deprecated r=emilio

Comment 2

[Robert Longson [:longsonr]]

https://treeherder.mozilla.org/jobs?repo=try&revision=a0f85df09f70e9fe66922ae49600d7b3ac83bbd3

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e294409c345f
Add console warning about SVGSVGElement.deselectAll() being deprecated r=emilio

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e294409c345f

Comment 5

[Sebastian Zartner [:sebo]]

Thank you for adding a patch, Robert! Unfortunately, the warning isn't logged to the console, though. I've tested with today's Nightly, i.e. 121.0a1 (2023-10-28).

The same happens for other deprecated APIs like SVGGraphicsElement.nearestViewportElement (requires the flag svg.nearestAndFarthestViewportElement.enabled to be enabled). So I assume it's a general issue.

Could you have a look at it?

Sebastian

Comment 6

[Robert Longson [:longsonr]]

Sorry if it doesn't work I've no idea where to start. I've done the same changes as other patches e.g. https://hg.mozilla.org/mozilla-central/rev/299b070981cf68e0beac40cdd86cb6bbe5802d2a

I suggest checking some other deprecated interfaces and raising a more general new bug with your finding.s

Comment 7

[Sebastian Zartner [:sebo]]

Fair enough. I'll try to get some more info and file a new bug.

Sebastian