Closed Bug 1302725 Opened 4 years ago Closed 4 years ago

plugin-doorhanger.inc.css references alerticon-info-negative.png which has been changed to SVG

Categories

(Firefox :: Site Identity, defect)

Product:
Firefox
Component:
Site Identity
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 51
Tracking Flags:
Tracking Status
firefox49 --- wontfix
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: florian, Assigned: florian)

References

Details

Attachments

(1 file)

Patch
1.08 KB, patch
dao
: review+
ritu
: approval-mozilla-beta+
Details | Diff | Splinter Review 
Found with the test I'm writing in bug 1302570: bug 1169679 replaced alerticon-info-negative.png with alerticon-info-negative.svg but didn't update the reference in browser/themes/shared/plugin-doorhanger.inc.css
Attached patch Patch — — Splinter Review
Attachment #8791188 - Flags: review?(dao+bmo)
Assignee: nobody → florian
Status: NEW → ASSIGNED
Comment on attachment 8791188 [details] [diff] [review]
Patch

We should probably uplift this...
Attachment #8791188 - Flags: review?(dao+bmo) → review+
https://hg.mozilla.org/integration/fx-team/rev/d7b5872f133f659cf85d5d1f2c8f46116de60ba1
Bug 1302725 - plugin-doorhanger.inc.css references alerticon-info-negative.png which has been changed to SVG, r=dao.
https://hg.mozilla.org/mozilla-central/rev/d7b5872f133f
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Comment on attachment 8791188 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: bug 1169679
[User impact if declined]: reference to missing image in CSS
[Describe test coverage new/current, TreeHerder]: on m-c and aurora
[Risks and why]: low, 1 line css fix
[String/UUID change made/needed]: no
Attachment #8791188 - Flags: approval-mozilla-beta?
Comment on attachment 8791188 [details] [diff] [review]
Patch

CSS only, low-risk, Beta50+
Attachment #8791188 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.