plugin-doorhanger.inc.css references alerticon-info-negative.png which has been changed to SVG

RESOLVED FIXED in Firefox 50

Status

()

Firefox
Site Identity and Permission Panels
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: florian, Assigned: florian)

Tracking

unspecified
Firefox 51
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox49 wontfix, firefox50 fixed, firefox51 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Found with the test I'm writing in bug 1302570: bug 1169679 replaced alerticon-info-negative.png with alerticon-info-negative.svg but didn't update the reference in browser/themes/shared/plugin-doorhanger.inc.css
(Assignee)

Comment 1

2 years ago
Created attachment 8791188 [details] [diff] [review]
Patch
Attachment #8791188 - Flags: review?(dao+bmo)
(Assignee)

Updated

2 years ago
Assignee: nobody → florian
Status: NEW → ASSIGNED
Comment on attachment 8791188 [details] [diff] [review]
Patch

We should probably uplift this...
Attachment #8791188 - Flags: review?(dao+bmo) → review+
(Assignee)

Comment 3

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/d7b5872f133f659cf85d5d1f2c8f46116de60ba1
Bug 1302725 - plugin-doorhanger.inc.css references alerticon-info-negative.png which has been changed to SVG, r=dao.

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d7b5872f133f
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51

Comment 5

2 years ago
Comment on attachment 8791188 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: bug 1169679
[User impact if declined]: reference to missing image in CSS
[Describe test coverage new/current, TreeHerder]: on m-c and aurora
[Risks and why]: low, 1 line css fix
[String/UUID change made/needed]: no
Attachment #8791188 - Flags: approval-mozilla-beta?

Updated

2 years ago
status-firefox50: --- → affected

Updated

2 years ago
status-firefox49: --- → wontfix

Comment 6

2 years ago
Comment on attachment 8791188 [details] [diff] [review]
Patch

CSS only, low-risk, Beta50+
Attachment #8791188 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 7

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/bccda1c9035c
status-firefox50: affected → fixed
You need to log in before you can comment on or make changes to this bug.