Closed Bug 1302760 Opened 5 years ago Closed 5 years ago

Make more of xpcAccessible work with proxies

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: michael.li11702, Assigned: michael.li11702)

Details

Attachments

(1 file, 1 obsolete file)

MozReview-Commit-ID: 2ototca0frl
Attachment #8791260 - Flags: review?(tbsaunde+mozbugs)
Assignee: nobody → mili
Comment on attachment 8791260 [details] [diff] [review]
Make xpcAccessible work with proxies

># HG changeset patch
># User Michael Li <michael.li11702@gmail.com>
>
>bug 1302760 - Make xpcAccessible work with proxies. r?tbsaunde

some of it already did, so say make more of it work.

>-  if (aIndex >= Intl()->ActionCount())
>-    return NS_ERROR_INVALID_ARG;
>+  if (ProxyAccessible* proxy = IntlGeneric().AsProxy()) {
>+#if defined(XP_WIN)
>+    return NS_ERROR_NOT_IMPLEMENTED;
>+#else
>+    proxy->ActionNameAt(aIndex, static_cast<nsString&>(aName));

that might happen to work, but you should instead put a nsAutoString on the stack and pass a pointer to that, then after the function copy the stack string to the argument.

>+    return NS_ERROR_NOT_IMPLEMENTED;
>+#else
>+    proxy->ActionDescriptionAt(aIndex, static_cast<nsString&>(aDescription));

same

r=me with those fixed
Attachment #8791260 - Flags: review?(tbsaunde+mozbugs) → review+
Summary: Make xpcAccessible work with proxies → Make more of xpcAccessible work with proxies
Keywords: checkin-needed
Attachment #8791260 - Attachment is obsolete: true
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8fd2ab696cf8
Make more of xpcAccessible work with proxies. r=tbsaunde
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8fd2ab696cf8
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.