1302760 - Make more of xpcAccessible work with proxies

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Michael Li]

MozReview-Commit-ID: 2ototca0frl

Comment 1

[Michael Li]

Attachment: Make xpcAccessible work with proxies

Comment 2

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8791260 [details] [diff] [review]
Make xpcAccessible work with proxies

># HG changeset patch
># User Michael Li <[e-mail]>
>
>bug 1302760 - Make xpcAccessible work with proxies. r?tbsaunde

some of it already did, so say make more of it work.

>-  if (aIndex >= Intl()->ActionCount())
>-    return NS_ERROR_INVALID_ARG;
>+  if (ProxyAccessible* proxy = IntlGeneric().AsProxy()) {
>+#if defined(XP_WIN)
>+    return NS_ERROR_NOT_IMPLEMENTED;
>+#else
>+    proxy->ActionNameAt(aIndex, static_cast<nsString&>(aName));

that might happen to work, but you should instead put a nsAutoString on the stack and pass a pointer to that, then after the function copy the stack string to the argument.

>+    return NS_ERROR_NOT_IMPLEMENTED;
>+#else
>+    proxy->ActionDescriptionAt(aIndex, static_cast<nsString&>(aDescription));

same

r=me with those fixed

Comment 3

[Michael Li]

Attachment: Make more of xpcAccessible work with proxies

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8fd2ab696cf8
Make more of xpcAccessible work with proxies. r=tbsaunde

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8fd2ab696cf8