Closed Bug 1302831 Opened 3 years ago Closed 3 years ago

TypeError: optimize_task_graph() takes at least 3 arguments (3 given)

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla51

People

(Reporter: gps, Assigned: martianwars)

References

Details

Attachments

(1 file)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c6e596ea6178&selectedJob=27484115

[task 2016-09-14T19:27:55.618988Z] Starting new HTTPS connection (1): cloud-mirror-production-us-east-1.s3.amazonaws.com
[task 2016-09-14T19:27:55.644518Z] "GET /https%3A%2F%2Fs3-us-west-2.amazonaws.com%2Ftaskcluster-public-artifacts%2FD1ruiRWsT_-feCGdqXcC8Q%2F0%2Fpublic%2Flabel-to-taskid.json HTTP/1.1" 200 2459
[task 2016-09-14T19:27:55.648963Z] Traceback (most recent call last):
[task 2016-09-14T19:27:55.649011Z]   File "/home/worker/checkouts/gecko/taskcluster/mach_commands.py", line 187, in taskgraph_action
[task 2016-09-14T19:27:55.649146Z]     return taskgraph.action.taskgraph_action(options)
[task 2016-09-14T19:27:55.649219Z]   File "/home/worker/checkouts/gecko/taskcluster/taskgraph/action.py", line 50, in taskgraph_action
[task 2016-09-14T19:27:55.649351Z]     existing_tasks=existing_tasks)
[task 2016-09-14T19:27:55.649386Z] TypeError: optimize_task_graph() takes at least 3 arguments (3 given)

Likely regression from bug 1286075.
Kalpesh, do you want to take a look?

Brian, bug 1302215 sprang out of a desire to avoid this sort of thing :)
Flags: needinfo?(kalpeshk2011)
There seem to be four parameters here https://dxr.mozilla.org/mozilla-central/source/taskcluster/taskgraph/optimize.py#17 which is leading to the regression. It will need to be added to the action task call as well.
Flags: needinfo?(kalpeshk2011)
Assignee: nobody → kalpeshk2011
Comment on attachment 8791374 [details]
Bug 1302831 - Downloading parameters.yml in the action task.

https://reviewboard.mozilla.org/r/78796/#review77562
Attachment #8791374 - Flags: review?(dustin) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/53afd8b15130
Downloading parameters.yml in the action task. r=dustin
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/53afd8b15130
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.