1302831 - TypeError: optimize_task_graph() takes at least 3 arguments (3 given)

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Gregory Szorc [:gps]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c6e596ea6178&selectedJob=27484115

[task 2016-09-14T19:27:55.618988Z] Starting new HTTPS connection (1): cloud-mirror-production-us-east-1.s3.amazonaws.com
[task 2016-09-14T19:27:55.644518Z] "GET /https%3A%2F%2Fs3-us-west-2.amazonaws.com%2Ftaskcluster-public-artifacts%2FD1ruiRWsT_-feCGdqXcC8Q%2F0%2Fpublic%2Flabel-to-taskid.json HTTP/1.1" 200 2459
[task 2016-09-14T19:27:55.648963Z] Traceback (most recent call last):
[task 2016-09-14T19:27:55.649011Z]   File "/home/worker/checkouts/gecko/taskcluster/mach_commands.py", line 187, in taskgraph_action
[task 2016-09-14T19:27:55.649146Z]     return taskgraph.action.taskgraph_action(options)
[task 2016-09-14T19:27:55.649219Z]   File "/home/worker/checkouts/gecko/taskcluster/taskgraph/action.py", line 50, in taskgraph_action
[task 2016-09-14T19:27:55.649351Z]     existing_tasks=existing_tasks)
[task 2016-09-14T19:27:55.649386Z] TypeError: optimize_task_graph() takes at least 3 arguments (3 given)

Likely regression from bug 1286075.

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Kalpesh, do you want to take a look?

Brian, bug 1302215 sprang out of a desire to avoid this sort of thing :)

Comment 2

[Kalpesh Krishna [:martianwars]]

There seem to be four parameters here https://dxr.mozilla.org/mozilla-central/source/taskcluster/taskgraph/optimize.py#17 which is leading to the regression. It will need to be added to the action task call as well.

Comment 3

[Kalpesh Krishna [:martianwars]]

Attachment: Bug 1302831 - Downloading parameters.yml in the action task.

Review commit: https://reviewboard.mozilla.org/r/78796/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/78796/

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8791374 [details]
Bug 1302831 - Downloading parameters.yml in the action task.

https://reviewboard.mozilla.org/r/78796/#review77562

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/53afd8b15130
Downloading parameters.yml in the action task. r=dustin

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/53afd8b15130