Closed Bug 1302833 Opened 5 years ago Closed 5 years ago

Fix CodeMirror height issue in new debugger

Categories

(DevTools :: Debugger, defect, P1)

Product:
DevTools
Component:
Debugger
Type:
defect

Tracking

(firefox51 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 51
Tracking Flags:
Tracking Status
firefox51 --- fixed

People

(Reporter: jlong, Assigned: jlong)

References

Details

Attachments

(1 file)

1302833.patch
1.59 KB, patch
Details | Diff | Splinter Review 
The editor does not expand with the panel height-wise.
Attached patch 1302833.patch — — Splinter Review 
Problem was the order how we loaded the styles: we were loading CodeMirror after us, so it's default styles was overriding the ones we set.
Assignee: nobody → jlong
Blocks: 1294139
Pushed by jlong@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/df3f78dc8bb7
fix CodeMirror styles in new debugger r=me
I would have pushed this last night but unfortunately the trees were closed.
Priority: -- → P1
https://hg.mozilla.org/mozilla-central/rev/df3f78dc8bb7
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.