Closed
Bug 1302833
Opened 6 years ago
Closed 6 years ago
Fix CodeMirror height issue in new debugger
Categories
(DevTools :: Debugger, defect, P1)
DevTools
Debugger
Tracking
(firefox51 fixed)
RESOLVED
FIXED
Firefox 51
Tracking | Status | |
---|---|---|
firefox51 | --- | fixed |
People
(Reporter: jlong, Assigned: jlong)
References
Details
Attachments
(1 file)
1.59 KB,
patch
|
Details | Diff | Splinter Review |
The editor does not expand with the panel height-wise.
Assignee | ||
Comment 1•6 years ago
|
||
Problem was the order how we loaded the styles: we were loading CodeMirror after us, so it's default styles was overriding the ones we set.
Assignee: nobody → jlong
Assignee | ||
Comment 2•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2554ba00cec6
Pushed by jlong@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/df3f78dc8bb7 fix CodeMirror styles in new debugger r=me
Assignee | ||
Comment 4•6 years ago
|
||
I would have pushed this last night but unfortunately the trees were closed.
Assignee | ||
Updated•6 years ago
|
Priority: -- → P1
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/df3f78dc8bb7
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Updated•4 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•