Fix CodeMirror height issue in new debugger

RESOLVED FIXED in Firefox 51

Status

P1
normal
RESOLVED FIXED
2 years ago
4 months ago

People

(Reporter: jlong, Assigned: jlong)

Tracking

unspecified
Firefox 51

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
The editor does not expand with the panel height-wise.
(Assignee)

Comment 1

2 years ago
Created attachment 8791360 [details] [diff] [review]
1302833.patch

Problem was the order how we loaded the styles: we were loading CodeMirror after us, so it's default styles was overriding the ones we set.
Assignee: nobody → jlong
(Assignee)

Updated

2 years ago
Blocks: 1294139

Comment 3

2 years ago
Pushed by jlong@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/df3f78dc8bb7
fix CodeMirror styles in new debugger r=me
(Assignee)

Comment 4

2 years ago
I would have pushed this last night but unfortunately the trees were closed.
(Assignee)

Updated

2 years ago
Priority: -- → P1

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/df3f78dc8bb7
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51

Updated

4 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.