1302862 - Open the panel when the sources have loaded

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Jason Laster [:jlast]]

We currently "open" the panel immediately. This means that outside tools like the console, don't know when the sources have loaded.

We should instead wait on the sources loading before declaring the panel opened.

Comment 1

[Jason Laster [:jlast]]

Attachment: init-page.patch

Comment 2

[James Long (:jlongster)]

Comment on attachment 8791387 [details] [diff] [review]
init-page.patch

Review of attachment 8791387 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good. Need to actually make sure this is going to behave how we're thinking, and I'll comment more in the github issue about it.

We'll need to land another bundle update first before pushing this, as this will break the current debugger.

::: devtools/client/debugger/new/panel.js
@@ +22,4 @@
>          threadClient: this.toolbox.threadClient,
>          tabTarget: this.toolbox.target
> +      }).then(() => {
> +        return this;

We convert this to use Task, but I don't care either way.

Comment 3

[James Long (:jlongster)]

Taking this as I'm going to land all this work and I cleaned it up with `Task`.

Comment 4

[James Long (:jlongster)]

Attachment: 1302862.patch

This most likely won't land until tomorrow because I'll need to do another try run after we land a bundle update, as this needs the tweak to `bootstrap` to return a promise.

Comment 5

[Brian Grinstead [:bgrins]]

Comment on attachment 8792661 [details] [diff] [review]
1302862.patch

Review of attachment 8792661 [details] [diff] [review]:
-----------------------------------------------------------------

It's ok from a DAMP end since this isn't regressing user-perceivable startup time

Comment 6

[Brian Grinstead [:bgrins]]

Joel, just a heads up that this bug will likely regress the 'debugger open' time in damp but it's shifting when the open event fires to make a couple things easier - it doesn't actually change user-perceived startup time

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

thanks :bgrins!  I will keep an eye out for it!

Comment 8

[James Long (:jlongster)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=005ce7743792

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/c2b240d60d5b
Initialize the debugger after the sources have loaded r=bgrins,jlast

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c2b240d60d5b