Closed Bug 1302922 Opened 4 years ago Closed 4 years ago

"Refresh driver waiting for the compositor for N seconds" logging is missing a space before seconds value

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

Just noticed this being logged to my terminal (by Nightly), when my system was under a decent amount of load:

{
[GFX1-]: Refresh driver waiting for the compositor for2.35138 seconds.
[GFX1-]: Refresh driver waiting for the compositor for1.1841 seconds.
[GFX1-]: Refresh driver waiting for the compositor for5.95352 seconds.
}

(Incidentally, this was at the front page of https://www.goldstar.com/ in a fresh profile on Linux)

As you can see, we're missing a space between "for" and the number of seconds there.  This is obviously a typo in the logging code -- I'm filing this bug on fixing that. Fix coming up.

(This logging was just landed a day ago in bug 1298085, it looks like -- marking this as blocking that bug.)
Comment on attachment 8791462 [details]
Bug 1302922: Add missing space in new "Refresh driver waiting" logging.

https://reviewboard.mozilla.org/r/78880/#review77522
Attachment #8791462 - Flags: review?(nical.bugzilla) → review+
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6e699b5ad321
Add missing space in new "Refresh driver waiting" logging. r=nical
https://hg.mozilla.org/mozilla-central/rev/6e699b5ad321
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.