1303043 - Missing tooltips in window host (dock buttons, frame chooser etc...)

Status: VERIFIED FIXED

(DevTools :: Framework, defect, P1)

Description

[Julian Descottes [:jdescottes]]

STRs:
- open devtools in a separate window host
- hover on any toolbox button, or on a dock button

ER: A tooltip should be displayed
AR: No tooltip is displayed

NB: the title tooltips for tool tabs (including the settings cog) are working fine, this is only about the buttons

Comment 1

[Julian Descottes [:jdescottes]]

Regression from the migration of said buttons from XUL to HTML. 
To work in XUL documents, HTML title attributes need to be able to use a XUL tooltip element.

A <tooltip> element is created in toolbox.xul and bound to the devtools frame in toolbox-hosts:
- http://searchfox.org/mozilla-central/source/devtools/client/framework/toolbox-hosts.js#1251

Something similar must be done for toolbox-window.xul

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1303043 - fix toolbox HTML tooltips in devtools window host;

Review commit: https://reviewboard.mozilla.org/r/79010/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79010/

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8791629 [details]
Bug 1303043 - fix toolbox HTML tooltips in devtools window host;

https://reviewboard.mozilla.org/r/79010/#review77772

Looks good to me, thanks for fixing it!

Honza

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d946881c4ee2
fix toolbox HTML tooltips in devtools window host;r=Honza

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: bug1303043.followup.patch

Oops, forgot to do the same for the browser toolbox!

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d946881c4ee2

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Too late for 49 but do we want to uplift that to 50?

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/6fef7e47113c
followup: add aHTMLTooltip in toolbox-window-process.xul;r=honza

Comment 9

[Julian Descottes [:jdescottes]]

Comment on attachment 8791629 [details]
Bug 1303043 - fix toolbox HTML tooltips in devtools window host;

I tried applying the current patch on aurora and it applied without conflicts so, not adding any new patch here.

Approval Request Comment
[Feature/regressing bug #]:1266419
[User impact if declined]:Tooltips are missing on devtools icons when devtools are in separate window
[Describe test coverage new/current, TreeHerder]: no new test. https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=85647c98a790
[Risks and why]: Minor markup change, only adding a new element and a new attribute.
[String/UUID change made/needed]: N/A

NB: I literally just landed a follow up https://hg.mozilla.org/integration/fx-team/rev/6fef7e47113c . This second fix is only for the browser console which is mostly used by advanced users, so not a big deal if the follow-up can't be uplifted.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8791629 [details]
Bug 1303043 - fix toolbox HTML tooltips in devtools window host;

50 moved to Beta today.

Comment 11

[Petruta Horea [:phorea]]

Verified as fixed using Nighty 51.0a1 2016-09-19 under Win 10 64-bit and Mac OS X 10.11.6.

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8791629 [details]
Bug 1303043 - fix toolbox HTML tooltips in devtools window host;

Recent regression that was verified fixed in Nightly, Beta50+

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6fef7e47113c

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/40c40afc1ab7

Comment 15

[Petruta Horea [:phorea]]

Verified as fixed using Firefox 50 beta 1 under Win 10 64-bit, Linux 14.04 64-bit and Mac OS X 10.11.