Closed Bug 1303043 Opened 3 years ago Closed 3 years ago

Missing tooltips in window host (dock buttons, frame chooser etc...)

Categories

(DevTools :: Framework, defect, P1)

defect

Tracking

(firefox48 unaffected, firefox49 wontfix, firefox50 verified, firefox51 verified)

VERIFIED FIXED
Firefox 51
Iteration:
51.3 - Sep 19
Tracking Status
firefox48 --- unaffected
firefox49 --- wontfix
firefox50 --- verified
firefox51 --- verified

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

(Whiteboard: [reserve-html])

Attachments

(2 files)

STRs:
- open devtools in a separate window host
- hover on any toolbox button, or on a dock button

ER: A tooltip should be displayed
AR: No tooltip is displayed

NB: the title tooltips for tool tabs (including the settings cog) are working fine, this is only about the buttons
Regression from the migration of said buttons from XUL to HTML. 
To work in XUL documents, HTML title attributes need to be able to use a XUL tooltip element.

A <tooltip> element is created in toolbox.xul and bound to the devtools frame in toolbox-hosts:
- http://searchfox.org/mozilla-central/source/devtools/client/framework/toolbox-hosts.js#1251

Something similar must be done for toolbox-window.xul
Blocks: 1266419
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Iteration: --- → 51.3 - Sep 19
Flags: qe-verify?
Priority: -- → P1
Whiteboard: [devtools-html]
Comment on attachment 8791629 [details]
Bug 1303043 - fix toolbox HTML tooltips in devtools window host;

https://reviewboard.mozilla.org/r/79010/#review77772

Looks good to me, thanks for fixing it!

Honza
Attachment #8791629 - Flags: review?(odvarko) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d946881c4ee2
fix toolbox HTML tooltips in devtools window host;r=Honza
Oops, forgot to do the same for the browser toolbox!
Attachment #8791957 - Flags: review?(odvarko)
Attachment #8791957 - Flags: review?(odvarko) → review+
Flags: qe-verify? → qe-verify+
QA Contact: petruta.rasa
Whiteboard: [devtools-html] → [reserve-html]
https://hg.mozilla.org/mozilla-central/rev/d946881c4ee2
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Too late for 49 but do we want to uplift that to 50?
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/6fef7e47113c
followup: add aHTMLTooltip in toolbox-window-process.xul;r=honza
Comment on attachment 8791629 [details]
Bug 1303043 - fix toolbox HTML tooltips in devtools window host;

I tried applying the current patch on aurora and it applied without conflicts so, not adding any new patch here.

Approval Request Comment
[Feature/regressing bug #]:1266419
[User impact if declined]:Tooltips are missing on devtools icons when devtools are in separate window
[Describe test coverage new/current, TreeHerder]: no new test. https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=85647c98a790
[Risks and why]: Minor markup change, only adding a new element and a new attribute.
[String/UUID change made/needed]: N/A

NB: I literally just landed a follow up https://hg.mozilla.org/integration/fx-team/rev/6fef7e47113c . This second fix is only for the browser console which is mostly used by advanced users, so not a big deal if the follow-up can't be uplifted.
Attachment #8791629 - Flags: approval-mozilla-aurora?
Comment on attachment 8791629 [details]
Bug 1303043 - fix toolbox HTML tooltips in devtools window host;

50 moved to Beta today.
Attachment #8791629 - Flags: approval-mozilla-aurora? → approval-mozilla-beta?
Verified as fixed using Nighty 51.0a1 2016-09-19 under Win 10 64-bit and Mac OS X 10.11.6.
Status: RESOLVED → VERIFIED
QA Whiteboard: [qe-dthtml]
Comment on attachment 8791629 [details]
Bug 1303043 - fix toolbox HTML tooltips in devtools window host;

Recent regression that was verified fixed in Nightly, Beta50+
Attachment #8791629 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified as fixed using Firefox 50 beta 1 under Win 10 64-bit, Linux 14.04 64-bit and Mac OS X 10.11.
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.