1303102 - Use autocommit for the run_sql command

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Ed Morley [:emorley]]

Currently if there is a timeout during run_sql, any changes made to the current database will be thrown away, since COMMIT is triggered manually by run_sql (`conn.commit()`) after the (`cursor.execute(sql_code)`).

This means that re-running run_sql repeatedly for an intensive change results in lots of busy-work but no changes saved (which has happened in bug 1303069).

Instead if we just enabled autocommit, changes would be kept.

People can always disable auto-commit within the provided SQL itself, using:
SET AUTOCOMMIT=0
  or
START TRANSACTION ... COMMIT

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] mozilla:runsql-autocommit > mozilla:master

Comment 2

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/c8802ef7ef6f0f3b91c66db9f5fe0edf0ed8498f
Bug 1303102 - Use autocommit for the run_sql command

This prevents changes from being discarded if the DB connection timed
out between the `.execute()` call being made, and it completing.