1303227 - Wrap xul linker such that the linking process does not get killed

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Enes Göktaş [:egoktas]]

The linking process of xul can get killed if it takes too long.
Wrap the xul linker such that it periodically prints a status message which will prevent the linking process from being killed.

Comment 1

[Enes Göktaş [:egoktas]]

Attachment: Bug 1303227 - Wrap libxul.so linker to prevent getting the linking process killed;

Review commit: https://reviewboard.mozilla.org/r/79104/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79104/

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8791833 [details]
Bug 1303227 - Wrap libxul.so linker to prevent getting the linking process killed;

https://reviewboard.mozilla.org/r/79104/#review78360

Please update the commit message to reflect the fact this removes the part that tracks memory usage of the process, and generalizes the wrapping to all platforms when linking libxul.

::: config/link.py:27
(Diff revision 1)
> -    with open(output_file, "w") as f:
> -        f.write("%d\n" % maxvsize)
>  
> -def measure_link_vsize(output_file, args):
> +def wrap_linker(args):
>      """
> -    Execute |args|, and measure the maximum virtual memory usage of the process,
> +    Execute |args| and pass resulting |proc| object to a second thread that 

trailing whitespace.

Comment 3

[Enes Göktaş [:egoktas]]

Comment on attachment 8791833 [details]
Bug 1303227 - Wrap libxul.so linker to prevent getting the linking process killed;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/79104/diff/1-2/

Comment 4

[Enes Göktaş [:egoktas]]

Comment on attachment 8791833 [details]
Bug 1303227 - Wrap libxul.so linker to prevent getting the linking process killed;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/79104/diff/2-3/

Comment 5

[Enes Göktaş [:egoktas]]

Comment on attachment 8791833 [details]
Bug 1303227 - Wrap libxul.so linker to prevent getting the linking process killed;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/79104/diff/3-4/

Comment 6

[Enes Göktaş [:egoktas]]

Ready to land? (I don't have L3 access)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/22d95521160b
Wrap libxul.so linker to prevent getting the linking process killed; r=glandium

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/22d95521160b