Closed Bug 1303227 Opened 4 years ago Closed 3 years ago

Wrap xul linker such that the linking process does not get killed

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox52 fixed)

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: egoktas, Assigned: egoktas)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The linking process of xul can get killed if it takes too long.
Wrap the xul linker such that it periodically prints a status message which will prevent the linking process from being killed.
Blocks: 1302891
Comment on attachment 8791833 [details]
Bug 1303227 - Wrap libxul.so linker to prevent getting the linking process killed;

https://reviewboard.mozilla.org/r/79104/#review78360

Please update the commit message to reflect the fact this removes the part that tracks memory usage of the process, and generalizes the wrapping to all platforms when linking libxul.

::: config/link.py:27
(Diff revision 1)
> -    with open(output_file, "w") as f:
> -        f.write("%d\n" % maxvsize)
>  
> -def measure_link_vsize(output_file, args):
> +def wrap_linker(args):
>      """
> -    Execute |args|, and measure the maximum virtual memory usage of the process,
> +    Execute |args| and pass resulting |proc| object to a second thread that 

trailing whitespace.
Attachment #8791833 - Flags: review?(mh+mozilla) → review+
Ready to land? (I don't have L3 access)
Flags: needinfo?(mh+mozilla)
Flags: needinfo?(mh+mozilla)
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/22d95521160b
Wrap libxul.so linker to prevent getting the linking process killed; r=glandium
https://hg.mozilla.org/mozilla-central/rev/22d95521160b
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Depends on: 1463465
Component: Build Config → General
Product: Firefox → Firefox Build System
Target Milestone: Firefox 52 → mozilla52
You need to log in before you can comment on or make changes to this bug.