Closed Bug 1303275 Opened 3 years ago Closed 3 years ago

Fix SharedMemory not declared error in ShmemPool

Categories

(Core :: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: tedd, Assigned: tedd)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

While working on Bug 1104619, I encountered a compile error, complaining about SharedMemory not being declared, in ShmemPool.cpp. This bug is for fixing the ShmemPool code.
Attachment #8791886 - Flags: review?(gpascutto)
Comment on attachment 8791886 [details] [diff] [review]
Fix ShmemPool code to resolve 'not declared' compiler error

Review of attachment 8791886 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/systemservices/ShmemPool.h
@@ +70,1 @@
>    // These 2 differ in what thread they can run on. GetIfAvailable

Comment is confusing now that code has moved around.
Attachment #8791886 - Flags: review?(gpascutto) → review+
Thanks.

Carry over r+ from :gcp.
Assignee: nobody → julian.r.hector
Attachment #8791886 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8791966 - Flags: review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a4754f5f3a00
Fix ShmemPool code to resolve 'not declared' compiler error. r=gcp
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a4754f5f3a00
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.