Closed Bug 1303277 Opened 4 years ago Closed 4 years ago

Adjust the refresh driver warning threshold in function of whether valgrind is running rather than just the build target

Categories

(Core :: Graphics, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: nical, Assigned: jseward)

References

Details

Attachments

(2 files)

This is a followup of bug 1302713
As Julian pointed out on irc, it would make more sense to check whether valgrind is running rather than whether valgrind could be running, with a define like:

#define REFRESH_WAIT_WARNING (RUNNING_ON_VALGRIND ? 10 : 1)
Something like this?
Attachment #8792028 - Flags: review?(jseward)
Attachment #8792028 - Flags: review?(jseward)
I found it a little difficult to follow the conditions there.  Also,
ASAN and Valgrind don't work together, but the patch implies they might.

Can I propose instead the following?  I find it clearer and it avoids
the need to create a new preprocessor symbol.
Attachment #8797394 - Flags: feedback?(nical.bugzilla)
Attachment #8797394 - Flags: feedback?(nical.bugzilla) → feedback+
Assignee: nical.bugzilla → jseward
Attachment #8797394 - Flags: review+
Pushed by jseward@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e00a24772316
Adjust the refresh driver warning threshold in function of whether valgrind is running rather than just the build target.  r=nical.
https://hg.mozilla.org/mozilla-central/rev/e00a24772316
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.