1303277 - Adjust the refresh driver warning threshold in function of whether valgrind is running rather than just the build target

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Nicolas Silva [:nical]]

This is a followup of bug 1302713
As Julian pointed out on irc, it would make more sense to check whether valgrind is running rather than whether valgrind could be running, with a define like:

#define REFRESH_WAIT_WARNING (RUNNING_ON_VALGRIND ? 10 : 1)

Comment 1

[Nicolas Silva [:nical]]

Attachment: Take RUNNING_ON_VALGRIND into account.

Something like this?

Comment 2

[Julian Seward [:jseward]]

Attachment: Alternative proposal

I found it a little difficult to follow the conditions there.  Also,
ASAN and Valgrind don't work together, but the patch implies they might.

Can I propose instead the following?  I find it clearer and it avoids
the need to create a new preprocessor symbol.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e00a24772316
Adjust the refresh driver warning threshold in function of whether valgrind is running rather than just the build target.  r=nical.

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e00a24772316