1303326 - Extend get_apk.py to be able to retrieve the latest nightly & aurora apk files

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

For now, get_apk.py only manages beta & release, we need to extend it to manage nightly & aurora.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1303326 - Extend get_apk.py to be able to retrieve the latest nightly & aurora apk files

Review commit: https://reviewboard.mozilla.org/r/79224/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79224/

Comment 2

[Sylvestre Ledru [:Sylvestre]]

To test it:
python get_apk.py --version 48.0.3
python get_apk.py --latest-nightly
python get_apk.py --latest-aurora
python get_apk.py --version 49.0b8

Comment 3

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8791955 [details]
Bug 1303326 - Extend get_apk.py to be able to retrieve the latest nightly & aurora apk files

https://reviewboard.mozilla.org/r/79224/#review78056

LGTM!

::: testing/mozharness/scripts/get_apk.py:126
(Diff revision 1)
>          if self.config["clean"]:
>              self.cleanup()
>          if self.config["version"] == "None":
>              if self.config["clean"]:
>                  sys.exit(0)
> -            self.fatal("Version is required")
> +        if self.config["version"] != "None" and (self.config["latest_nightly"] or self.config["latest_aurora"]):

Nit: I wonder if we use None as a keyword, instead of a string here.
This would enable to write `self['version'] is not None`

::: testing/mozharness/scripts/get_apk.py:157
(Diff revision 1)
>              ScriptMixin.rmtree(self, self.download_dir)
>              self.fatal("Downloading " + apk_file + " failed!")
>  
>      # Helper functions
>      def generate_url(self, version, build, locale, api_suffix, arch_file):
> -        return "https://ftp.mozilla.org/pub/mozilla.org/mobile/candidates/" + version + "-candidates/build" + build + \
> +        base_url = "https://ftp.mozilla.org/pub/mobile"

Nit: base_url can be defined as a class constant

Comment 4

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8791955 [details]
Bug 1303326 - Extend get_apk.py to be able to retrieve the latest nightly & aurora apk files

https://reviewboard.mozilla.org/r/79224/#review78058

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8791955 [details]
Bug 1303326 - Extend get_apk.py to be able to retrieve the latest nightly & aurora apk files

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/79224/diff/1-2/

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8791955 [details]
Bug 1303326 - Extend get_apk.py to be able to retrieve the latest nightly & aurora apk files

https://reviewboard.mozilla.org/r/79224/#review78056

> Nit: I wonder if we use None as a keyword, instead of a string here.
> This would enable to write `self['version'] is not None`

I tried in the past and I think we are getting a string which is "None" here.
I will land without this change but happy to try with you later.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b321d41d837
Extend get_apk.py to be able to retrieve the latest nightly & aurora apk files r=jlorenzo

Comment 8

[Johan Lorenzo [:jlorenzo]]

Per comment 7.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9b321d41d837