Closed
Bug 1303339
Opened 9 years ago
Closed 9 years ago
The animated sharing icons of the control center panel never go to full opacity
Categories
(Firefox :: Site Identity, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox48 | --- | unaffected |
| firefox49 | --- | unaffected |
| firefox50 | --- | unaffected |
| firefox51 | --- | verified |
| firefox52 | --- | verified |
People
(Reporter: florian, Assigned: florian)
References
Details
(Keywords: regression, Whiteboard: [fxprivacy])
Attachments
(1 file)
|
923 bytes,
patch
|
dao
:
review+
gchang
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
This regressed with https://hg.mozilla.org/integration/mozilla-inbound/rev/3e394b4e9b6f#l6.18 / bug 1022601
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8791973 -
Flags: review?(dao+bmo)
|
||
Updated•9 years ago
|
Attachment #8791973 -
Flags: review?(dao+bmo) → review+
|
||
Updated•9 years ago
|
status-firefox48:
--- → unaffected
status-firefox49:
--- → unaffected
status-firefox50:
--- → unaffected
status-firefox51:
--- → affected
Version: unspecified → 51 Branch
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/fx-team/rev/57c699cd9f26
The animated sharing icons of the control center panel should go to full opacity. r=dao
Keywords: checkin-needed
|
||
Comment 3•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
|
|
Assignee | |
Comment 4•9 years ago
|
||
Comment on attachment 8791973 [details] [diff] [review]
Fix
Approval Request Comment
[Feature/regressing bug #]: the broken feature is bug 1206233, the bug causing the regression is bug 1022601. Both landed for 51.
[User impact if declined]: animated sharing indicator always partially transparent.
[Describe test coverage new/current, TreeHerder]: QA can verify. No automated tests for this trivial CSS change.
[Risks and why]: very low, one line CSS fix.
[String/UUID change made/needed]: none.
Attachment #8791973 -
Flags: approval-mozilla-aurora?
|
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8791973 [details] [diff] [review]
Fix
This patch fixes a UI regression of animated sharing icons. Take it in 51 aurora.
Attachment #8791973 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
||
Comment 6•9 years ago
|
||
| bugherder uplift | ||
|
|
||
Updated•9 years ago
|
Iteration: --- → 52.1 - Oct 3
|
||
Comment 7•9 years ago
|
||
Confirming the fix across platform using:
- latest Fx 52.0a2 Aurora, build ID 20170112004017
- Firefox 51.0b13, build ID 20170109165508.
Status: RESOLVED → VERIFIED
QA Contact: cornel.ionce
You need to log in
before you can comment on or make changes to this bug.
Description
•