1303355 - Error in parsing value for -moz-box-pack, chrome://mozapps/skin/extensions/newaddon.css

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P5)

Description

[Florian Quèze [:florian]]

Error in parsing value for ‘-moz-box-pack’.  Declaration dropped." {file: "chrome://mozapps/skin/extensions/newaddon.css" line: 94 column: 17 source: "  -moz-box-pack: stretch;"}

The error is at this line:
http://searchfox.org/mozilla-central/rev/f6c298b36db67a7109079c0dd7755f329c1d58e2/toolkit/themes/shared/extensions/newaddon.inc.css#105

Comment 1

[Florian Quèze [:florian]]

Given that in its current state it does nothing (but a warning), I think we can safely just remove the line.

Comment 2

[Vincent Lequertier]

Hello, can I work on this bug please? :-)

Comment 3

[Florian Quèze [:florian]]

Sure. The first step will be to download the Firefox source code (if you haven't done this yet). Then follow the indications in the bug description to find the exact line of code that's causing the error.

Comment 4

[Vincent Lequertier]

Attachment: remove-unused-line.patch

Comment 5

[Florian Quèze [:florian]]

Comment on attachment 8797763 [details] [diff] [review]
remove-unused-line.patch

Thanks for the patch.

Sorry, I made a mistake in the description of the bug, the line that is causing the CSS error is "-moz-box-pack: stretch;", it's at this line: http://searchfox.org/mozilla-central/rev/f6c298b36db67a7109079c0dd7755f329c1d58e2/toolkit/themes/shared/extensions/newaddon.inc.css#95

Could you please configure mercurial so that your patch contains 8 lines of context next time?
./mach mercurial-setup
should do it automatically for you.

Comment 6

[Vincent Lequertier]

How can I test by myself that the error disappear ?

How did you the error ?

Error in parsing value for ‘-moz-box-pack’.  Declaration dropped." {file: "chrome://mozapps skin/extensions/newaddon.css" line: 94 column: 17 source: "  -moz-box-pack: stretch;"}'

Thanks

Comment 7

[Florian Quèze [:florian]]

(In reply to sky from comment #6)
> How can I test by myself that the error disappear ?
> 
> How did you the error ?

The way I saw the error is by applying the patch in bug 1221383 and then running:
./mach test browser/base/content/test/general/browser_parsable_css.js

This CSS file is used by the about:newaddon page, but I don't see a simple way to get it to open. (attachment 8523525 [details] shows what this page looks like).

Comment 8

[Vincent Lequertier]

Thanks

Comment 9

[Vincent Lequertier]

Attachment: remove-unused-line.patch

Comment 10

[Florian Quèze [:florian]]

Comment on attachment 8801187 [details] [diff] [review]
remove-unused-line.patch

Looks good, thanks!

Your patch doesn't include a commit message or author information, usually on hg changesets the author is in the form: Full Name <email>

Comment 11

[Florian Quèze [:florian]]

(In reply to Florian Quèze [:florian] [:flo] from comment #10)

> Your patch doesn't include a commit message or author information, usually
> on hg changesets the author is in the form: Full Name <email>

Ah, I see you used "Vincent Lequertier <[e-mail]>" in other bugs you fixed.

Comment 12

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/02397de5394827e5de1623c9ed13493222bcc048
Bug 1303355 - Error in parsing value for -moz-box-pack, chrome://mozapps/skin/extensions/newaddon.css, r=florian.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/02397de53948

Comment 14

[Vincent Lequertier]

So strange, I have those lines in ~/.hgrc:

[ui]
username = Vincent Lequertier <[e-mail]>


But it seems like it wasn't honored when I generated the patch.

Thank you for your help!