1303359 - No highlight on dark high contrast OS themes

Status: RESOLVED WORKSFORME

(Toolkit :: Find Toolbar, defect)

Description

[Simona Badau, Desktop QA]

Attachment: Screenshot with the issue

Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20160916030204

[Affected versions]:
Nightly 51

[Affected platforms]:
Windows 10

[Prerequisites]:
Activate a high contrast theme.
- "Windows: Go to Personalize> Themes> Theme Settings and activate a High Contrast Theme.

[Steps to reproduce]:
1. Open Nightly (be sure you have "findbar.modalHighlight" and "findbar.highlightAll" set to true).
2. Go to this page: https://developer.mozilla.org/en-US/docs/Web
3. Press CTRL+F to open Find toolbar.
4. Search for any word that appears on the page (e.g "developers").

[Expected result]:
The background should be dimmed and all the matches should be highlighted.

[Actual result]:
The background is not sufficiently dimmed to get your attention and no match is highlighted. Please see the attached screenshot for more details.

[Regression range]:
- I'll investigate and post the results as soon as possible.

[Additional notes]:
- When "findbar.modalHighlight" and "findbar.highlightAll" are set to false, the matches are highlighted. 
- could not reproduce the issue on Ubuntu 16.04

Comment 1

[Mike de Boer [:mikedeboer]]

Dão, is this be something you'd be interested in working on, perhaps?

Comment 2

[Dão Gottwald [:dao]]

How do you style the matches? Is this from a UA stylesheet or CSS injected into the page? If it's the latter, you can't effectively prevent High Contrast mode disabling your colors like it does for ordinary web content (as long as we don't have bug 957988 fixed.)

Comment 3

[Mike de Boer [:mikedeboer]]

The matches are styled using the 'style' attribute directly on the elements. This was done for performance reasons. The code doing all the highlighting can be found in FinderHighlighter.jsm

Comment 4

[Giorgia Nichita, Release Desktop QA]

I am closing this as WFM as it is no longer reproducible with our latest nightly build 132.0a1 (2024-09-30) using Win 10 and macOS 11.