1303454 - [FlyWeb] publishServer() broken on Fennec

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Flyweb, defect)

Description

[Justin D'Arcangelo [:justindarc]]

Visiting https://flyweb.github.io/ calls `navigator.publishServer()` and does not bring up the permissions prompt on Fennec Nightly. The following error is logged to the GeckoConsole:

  [JavaScript Error: "[Exception... "Failure"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: no]"] 

Additionally, in DEBUG builds, the browser crashes with the following:

  Assertion failure: removed, at /Users/Justin/Development/Mozilla/mozilla-central/dom/flyweb/FlyWebService.cpp:1109

NOTE: This does not affect the ability to do FlyWeb discovery or connect to FlyWeb services on Fennec. This is only an issue with starting FlyWeb services from web pages using `navigator.publishServer()`.

Comment 1

[Kannan Vijayan [:djvj]]

Is this intermittent or does it always happen?

Comment 2

[Kannan Vijayan [:djvj]]

Looked into this.  This is being caused by the addon-check failing on fennec.  Looking into how to fix (simple fix is to remove the addon check, but I doubt ehsan will be happy with that).

Comment 3

[Kannan Vijayan [:djvj]]

Attachment: fix-fennec-flyweb-addon-check.patch

The "flyweb addon check" in the content-permission check fails on Android because the path it looks for isn't present in the fennec add-on.  This change just refactors the addon-checking code into a separate function, where we look for one of two resource paths - one of which succeeds on desktop and the other on fennec.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/acdba157c88f
Change FlyWeb addon check to use paths from both desktop and android resources. r=ehsan

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/acdba157c88f

Comment 6

[Tyler]

[Tracking Requested - why for this release]: It is very hard to fix been on it for 2 weeks and cant figure out the source of the bug I tracked the last user and it never showed me th info i need so i suggest keeping an eye on thi,s bug

Comment 7

[Marcia Knous [:marcia]]

Tracking 52- since this is now resolved fixed.