Closed Bug 1303480 Opened 5 years ago Closed 5 years ago

Intermittent devtools/client/webide/test/test_manifestUpdate.html | Test timed out.

Categories

(DevTools Graveyard :: WebIDE, defect, P3)

defect

Tracking

(firefox50 unaffected, firefox51 fixed, firefox52 fixed)

RESOLVED FIXED
Firefox 52
Tracking Status
firefox50 --- unaffected
firefox51 --- fixed
firefox52 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: ochameau)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Attached patch patch v1Splinter Review
Not sure it is that, but it is worth a try.
"details" event can be fired on document load, whereas I imagine we expect the one
fired when the project is validated.
Comment on attachment 8792794 [details] [diff] [review]
patch v1

Review of attachment 8792794 [details] [diff] [review]:
-----------------------------------------------------------------

Jan, I was wondering if you could review this very simple patch while jryans is away this week?
There is just me and jryans still around webide codebase...
Attachment #8792794 - Flags: review?(janx)
Assignee: nobody → poirot.alex
Attachment #8792794 - Flags: review?(janx) → review?(jryans)
Comment on attachment 8792794 [details] [diff] [review]
patch v1

Review of attachment 8792794 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds fine to me if it fixes the issue on try.
Attachment #8792794 - Flags: review?(jryans) → review+
https://hg.mozilla.org/integration/fx-team/rev/52cfd2babd94fa8452128940b50614cc12660785
Bug 1303480 - Fix test_manifestUpdate.html intermittent "invalid 'in' operand project.manifest". r=jryans
https://hg.mozilla.org/mozilla-central/rev/52cfd2babd94
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.