1303514 - correct comments and simplify test messages in webcompat system add-on

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P5)

Description

[Robert Helmer [:rhelmer]]

Matt used the webcompat system add-on as a template for bug 1303469 and made some improvements. We should pull these into webcompat too, and reduce the delta there as much as possible.

See bug 1303469 comment 3.

Comment 1

[Robert Helmer [:rhelmer]]

Attachment: Bug 1303514 - correct comments and simplify test messages in webcompat system add-on

Review commit: https://reviewboard.mozilla.org/r/79382/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79382/

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8792178 [details]
Bug 1303514 - correct comments and simplify test messages in webcompat system add-on

https://reviewboard.mozilla.org/r/79382/#review77916

::: browser/extensions/webcompat/bootstrap.js:1
(Diff revision 1)
>  /* -*- indent-tabs-mode: nil; js-indent-level: 2 -*- */

The reason I deleted this from the formautofill extension is because 2 spaces is the default for mozilla-central JS so the line is redundant.

Comment 3

[Robert Helmer [:rhelmer]]

Comment on attachment 8792178 [details]
Bug 1303514 - correct comments and simplify test messages in webcompat system add-on

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/79382/diff/1-2/

Comment 4

[Robert Helmer [:rhelmer]]

Comment on attachment 8792178 [details]
Bug 1303514 - correct comments and simplify test messages in webcompat system add-on

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/79382/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64fd93d6dbf2
correct comments and simplify test messages in webcompat system add-on r=MattN

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/64fd93d6dbf2