Closed Bug 1303638 Opened 4 years ago Closed 4 years ago
.webkit Relative Path does not include root directory
See attached test case. When uploading a directory with the structure dir `-- file the `webkitRelativePath` in Blink will be dir/file while in Firefox it is just /file resulting in the server being unable to know the name of the directory that was uploaded.
Is this intentional?
This fixes the dropbox issue as well \o/
Assignee: nobody → amarchesini
Attachment #8793675 - Flags: review?(bugs)
oh, we need this then to branches asap. /me reviews
Comment on attachment 8793675 [details] [diff] [review] upload.patch We want this for FF50 and FF51 too. Make this bug to block the dropbox issue? And ask approvals.
Attachment #8793675 - Flags: review?(bugs) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/264fb5fec2d8 file.webkitRelativePath must contain the leafName of the parent directory, r=smaug
[Tracking Requested - why for this release]: We enabled this API for FF50, so better to fix issues in it before FF50 being the release version.
Comment on attachment 8793675 [details] [diff] [review] upload.patch Approval Request Comment [Feature/regressing bug #]:bug 1258490 [User impact if declined]: We return wrong webkit path and this can break the compatibility with websites. [Describe test coverage new/current, TreeHerder]: we have mochitests [Risks and why]: not really. The patch is very easy. [String/UUID change made/needed]: none
Hello silverwind, could you please verify this issue is fixed as expected on a latest Nightly build? Thanks!
Comment on attachment 8793675 [details] [diff] [review] upload.patch planned feature work for 50, Aurora51+, Beta50+
The change appears to be working fine on my side in today's Nightly, thanks!
(In reply to silverwind from comment #16) > The change appears to be working fine on my side in today's Nightly, thanks! Awesome! Thanks a lot for the verification.
You need to log in before you can comment on or make changes to this bug.