file.webkitRelativePath does not include root directory

VERIFIED FIXED in Firefox 50

Status

()

--
major
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: me, Assigned: baku)

Tracking

({site-compat})

Trunk
mozilla52
site-compat
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox49 unaffected, firefox50+ fixed, firefox51+ fixed, firefox52+ verified)

Details

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
Created attachment 8792343 [details]
wkd.html

See attached test case. When uploading a directory with the structure

dir
`-- file

the `webkitRelativePath` in Blink will be

    dir/file

while in Firefox it is just

   /file

resulting in the server being unable to know the name of the directory that was uploaded.
Is this intentional?
Flags: needinfo?(amarchesini)
(Assignee)

Comment 2

2 years ago
Created attachment 8793675 [details] [diff] [review]
upload.patch

This fixes the dropbox issue as well \o/
Assignee: nobody → amarchesini
Flags: needinfo?(amarchesini)
Attachment #8793675 - Flags: review?(bugs)

Comment 3

2 years ago
oh, we need this then to branches asap.
/me reviews

Comment 4

2 years ago
Comment on attachment 8793675 [details] [diff] [review]
upload.patch

We want this for FF50 and FF51 too. Make this bug to block the dropbox issue?
And ask approvals.
Attachment #8793675 - Flags: review?(bugs) → review+

Comment 5

2 years ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/264fb5fec2d8
file.webkitRelativePath must contain the leafName of the parent directory, r=smaug

Comment 6

2 years ago
[Tracking Requested - why for this release]:
We enabled this API for FF50, so better to fix issues in it before FF50 being the release version.
status-firefox49: --- → unaffected
status-firefox50: --- → affected
status-firefox52: --- → affected
tracking-firefox50: --- → ?
tracking-firefox51: --- → ?
tracking-firefox52: --- → ?
(Assignee)

Comment 7

2 years ago
Comment on attachment 8793675 [details] [diff] [review]
upload.patch

Approval Request Comment
[Feature/regressing bug #]:bug 1258490
[User impact if declined]: We return wrong webkit path and this can break the compatibility with websites.
[Describe test coverage new/current, TreeHerder]: we have mochitests
[Risks and why]: not really. The patch is very easy.
[String/UUID change made/needed]: none
Attachment #8793675 - Flags: approval-mozilla-beta?
Attachment #8793675 - Flags: approval-mozilla-aurora?
Tracking 52+ for this API issue.
tracking-firefox52: ? → +

Updated

2 years ago
Keywords: site-compat

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/264fb5fec2d8
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Hello silverwind, could you please verify this issue is fixed as expected on a latest Nightly build? Thanks!
Flags: needinfo?(me)
Webkit directory is planned for Fx50.
tracking-firefox50: ? → +
tracking-firefox51: ? → +
Comment on attachment 8793675 [details] [diff] [review]
upload.patch

planned feature work for 50, Aurora51+, Beta50+
Attachment #8793675 - Flags: approval-mozilla-beta?
Attachment #8793675 - Flags: approval-mozilla-beta+
Attachment #8793675 - Flags: approval-mozilla-aurora?
Attachment #8793675 - Flags: approval-mozilla-aurora+

Comment 14

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/3c170bce64e3
status-firefox51: affected → fixed
Flags: in-testsuite+

Comment 15

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/c8d78d3fa201
status-firefox50: affected → fixed
(Reporter)

Comment 16

2 years ago
The change appears to be working fine on my side in today's Nightly, thanks!
Flags: needinfo?(me)
(In reply to silverwind from comment #16)
> The change appears to be working fine on my side in today's Nightly, thanks!

Awesome! Thanks a lot for the verification.
Status: RESOLVED → VERIFIED
status-firefox52: fixed → verified
You need to log in before you can comment on or make changes to this bug.