If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Build Clang 3.8.1 package with CFI patches to support Firefox

NEW
Assigned to

Status

()

Firefox
Build Config
a year ago
6 months ago

People

(Reporter: egoktas, Assigned: egoktas)

Tracking

(Depends on: 1 bug, Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

a year ago
Build Clang 3.8.1 package with CFI patches to support Firefox:
- add possibility to print debug info in __cfi_check instead of crashing
- whitelist vtable links
- support dlopen
(Assignee)

Updated

a year ago
Blocks: 1302891
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Depends on: 1286788
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Attachment #8792366 - Attachment is obsolete: true
Comment hidden (mozreview-request)

Comment 6

a year ago
mozreview-review
Comment on attachment 8792360 [details]
Bug 1303644 - Build Clang package with patches to support Firefox;

https://reviewboard.mozilla.org/r/79410/#review81640

::: build/build-clang/build-clang.py:148
(Diff revision 3)
>  def get_platform():
>      p = platform.system()
>      if p == "Darwin":
>          return "macosx64"
>      elif p == "Linux":
> -        if platform.architecture() == "AMD64":
> +        if platform.machine().endswith("64"):

This doesn't seem related. If there is an issue with those tests, please file a separate bug.

::: build/build-clang/clang-static-analysis-linux64.json:24
(Diff revision 3)
> +          "llvm-replace-ud2-with-debug-prints-cfi-vcall-dso.patch",
> +          "llvm-clang-whitelist-related-classes-vtables.patch",
> +          "llvm-compiler-rt-dlopen-support.patch"

Have these patches been reviewed upstream?
Attachment #8792360 - Flags: review?(mh+mozilla)
You need to log in before you can comment on or make changes to this bug.