1303644 - Build Clang 3.8.1 package with CFI patches to support Firefox

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Enes Göktaş [:egoktas]]

Build Clang 3.8.1 package with CFI patches to support Firefox:
- add possibility to print debug info in __cfi_check instead of crashing
- whitelist vtable links
- support dlopen

Comment 1

[Enes Göktaş [:egoktas]]

Attachment: Bug 1303644 - Build Clang package with patches to support Firefox;

Review commit: https://reviewboard.mozilla.org/r/79410/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79410/

Comment 2

[Enes Göktaş [:egoktas]]

Comment on attachment 8792360 [details]
Bug 1303644 - Build Clang package with patches to support Firefox;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/79410/diff/1-2/

Comment 3

[Enes Göktaş [:egoktas]]

Attachment: Bug 1303644 - Build Clang with LLVMgold.so (Bug 1286788)

Review commit: https://reviewboard.mozilla.org/r/79422/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79422/

Comment 4

[Enes Göktaş [:egoktas]]

Comment on attachment 8792360 [details]
Bug 1303644 - Build Clang package with patches to support Firefox;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/79410/diff/2-3/

Comment 5

[Enes Göktaş [:egoktas]]

Attachment: Bug 1303644 - Build Clang with LLVMgold.so (Bug 1286788)

Review commit: https://reviewboard.mozilla.org/r/81574/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/81574/

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 8792360 [details]
Bug 1303644 - Build Clang package with patches to support Firefox;

https://reviewboard.mozilla.org/r/79410/#review81640

::: build/build-clang/build-clang.py:148
(Diff revision 3)
>  def get_platform():
>      p = platform.system()
>      if p == "Darwin":
>          return "macosx64"
>      elif p == "Linux":
> -        if platform.architecture() == "AMD64":
> +        if platform.machine().endswith("64"):

This doesn't seem related. If there is an issue with those tests, please file a separate bug.

::: build/build-clang/clang-static-analysis-linux64.json:24
(Diff revision 3)
> +          "llvm-replace-ud2-with-debug-prints-cfi-vcall-dso.patch",
> +          "llvm-clang-whitelist-related-classes-vtables.patch",
> +          "llvm-compiler-rt-dlopen-support.patch"

Have these patches been reviewed upstream?

Comment 7

[Kim Moir [:kmoir] ET]

I think this can be closed - we now build with a newer version of clang and we have a toolchain task to build clang.