Closed Bug 1303681 Opened 5 years ago Closed 5 years ago

SVG element in which there is '<a xlink:href="#">' can not be focused by TAB key

Categories

(Core :: SVG, defect)

defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1302341

People

(Reporter: xdymzhang, Assigned: daoshengmu)

References

Details

Attachments

(1 file)

Attached file test.html
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/601.7.7 (KHTML, like Gecko) Version/9.1.2 Safari/601.7.7

Steps to reproduce:

I created a test.html in which there is a SVG, and under the SVG there are some <a> tags.


Actual results:

The <a> element can not be focused by TAB key, even if "tabindex" is added.


Expected results:

All the circles in the <a> element can be focused by TAB key
Component: Untriaged → SVG
Product: Firefox → Core
Version: 51 Branch → Trunk
Daosheng, can you look at this one?
Flags: needinfo?(dmu)
(In reply to Cameron McCormack (:heycam) from comment #1)
> Daosheng, can you look at this one?

Sure. I will take a look at on this bug this week. Btw, it is the same to Bug 1302341.
Flags: needinfo?(dmu)
Hi there, I noticed that Nightly build on Windows can work well now, but not on Mac, FYI.
Assignee: nobody → dmu
Status: UNCONFIRMED → NEW
Ever confirmed: true
I notice it can be fixed by removing our old override function in SVGAElement (https://dxr.mozilla.org/mozilla-central/rev/c55bcb7c777ea09431b4d16903ed079ae5632648/dom/svg/SVGAElement.cpp#193). We should just use nsSVGElement::IsFocusableInternal().

Another thing we need to follow up is why text's bounding box in SVG link element is wrong. I will keep investigating it in Bug 1302341. The good news is it is very close to be resolved.
Hi Daosheng,
Is this bug fixed already?
Regards,
xdymzhang

(In reply to Daosheng Mu[:daoshengmu] from comment #4)
> I notice it can be fixed by removing our old override function in
> SVGAElement
> (https://dxr.mozilla.org/mozilla-central/rev/
> c55bcb7c777ea09431b4d16903ed079ae5632648/dom/svg/SVGAElement.cpp#193). We
> should just use nsSVGElement::IsFocusableInternal().
> 
> Another thing we need to follow up is why text's bounding box in SVG link
> element is wrong. I will keep investigating it in Bug 1302341. The good news
> is it is very close to be resolved.
See Also: → 1302341
Hi xdymzhang,

There is a workable patch at bug 1302341. Currently, it is under the review process. Hope it would be soon.
Because Bug 1302341 has landed, we can make it as resolved.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1302341
You need to log in before you can comment on or make changes to this bug.