1303722 - Use addEventListener(..., {once: true}) in mailnews/ and editor/

Status: RESOLVED FIXED

(MailNews Core :: Backend, enhancement)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: editor, v1

Similar to bug 1300339.

See https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener

Bug 1287706 added support for the 'once' option in addEventListener which works like an removeEventListener executed when the callback gets executed for the first time.

Advantage: add + remove in one statement, remove can't get lost

Try push: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=2dfefad3054a

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: mailnews, v1

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 8792479 [details] [diff] [review]
mailnews, v1

Review of attachment 8792479 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good thx! r=mkmelin

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 8792478 [details] [diff] [review]
editor, v1

Review of attachment 8792478 [details] [diff] [review]:
-----------------------------------------------------------------

Reviewers also have to learn new things, this time arrow function expressions ;-)
r=jorgk

::: editor/ui/dialogs/content/EdFieldSetProps.js
@@ +70,5 @@
>        gDialog.editText.checked = false;
>        gDialog.editText.disabled = false;
>        gDialog.legendText.disabled = true;
> +      gDialog.editText.addEventListener("command",
> +        () =>  Services.prompt.alert(window, GetString("Alert"), GetString("EditTextWarning")),

Nit. Two spaces after =>
Please fix when landing.

Comment 4

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/c5da3041922b
https://hg.mozilla.org/comm-central/rev/2e7247627920
Landed after OK from author. Commit message fixed, white-space issue fixed.