1303734 - Store textual page metadata from web pages to database in Swift

Status: RESOLVED FIXED

(Firefox for iOS :: Data Storage, defect, P1)

Description

[Stephan Leroux [:sleroux]]

Now that we're able to pull down metadata for each pages [1], we need a place to store this data (probably in SQLite) and a way of exposing this data to other parts of the app. At the moment, the only known consumer of this data is the new Activity Stream panel to show richer highlights.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1297703

Comment 1

[Richard Newman [:rnewman]]

Bug 1301717 is the Android side of this. 

Here's the desktop add-on's schema:

https://github.com/mozilla/activity-stream/blob/master/addon/MetadataStore.js

We'll be storing similar in Tofino using Datomish, eventually -- it's sparse, growing, graph-shaped, and all that good stuff.

Comment 2

[Stephan Leroux [:sleroux]]

Moving to backlog for now until we prioritize

Comment 3

[Stephan Leroux [:sleroux]]

Will be part of MVP definition so moving to P2.

Comment 4

[Stephan Leroux [:sleroux]]

Refining bug to focus on only textual data from web page metadata. Images will be filed as another bug.

Comment 5

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2181

Comment 6

[Stephan Leroux [:sleroux]]

Comment on attachment 8803037 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2181

Forgot to add :rnewman for feedback on SQLite-ness.

Comment 7

[Stephan Leroux [:sleroux]]

master https://github.com/mozilla-mobile/firefox-ios/pull/2181