Closed Bug 1303800 Opened 3 years ago Closed 3 years ago

Beta devtools tests failing with browser_net_cause.js | A promise chain failed to handle a rejection: - at chrome://mochitests/content/browser/devtools/client/netmonitor/test/browser_net_cause.js:118 - TypeError: stacktrace[j] is undefined

Categories

(DevTools :: Netmonitor, defect, blocker)

defect
Not set
blocker

Tracking

(firefox50 fixed, firefox51 fixed, firefox52 fixed)

RESOLVED FIXED
Firefox 52
Tracking Status
firefox50 --- fixed
firefox51 --- fixed
firefox52 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: jsnajdr)

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

Jarda, can you take a look at this, please?
Flags: needinfo?(jsnajdr)
The test depends on javascript.options.asyncstack being set to "true". It's indeed "true" in central and aurora, but isn't when defined(RELEASE_BUILD). Is RELEASE_BUILD defined both in mozilla-release and mozilla-beta?

I'll post a simple fix soon.
Assignee: nobody → jsnajdr
Flags: needinfo?(jsnajdr)
Thanks. Yes, RELEASE_BUILD is true for beta and release.
Severity: normal → blocker
Version of the patch intended for mozilla-central - patch browser_net_cause.js and browser_net_frame.js to turn on javascript.options.asyncstack.

The patch for mozilla-beta will be slightly different.
Attachment #8792766 - Flags: review?(poirot.alex)
Version of the patch for mozilla-beta. Fixes only browser_net_cause.js, as browser_net_frame.js in only in aurora now. Also, properly rebased for mozilla-beta.
Attachment #8792770 - Flags: review?(poirot.alex)
Attachment #8792766 - Flags: review?(poirot.alex) → review+
Attachment #8792770 - Flags: review?(poirot.alex) → review+
Please checkin. One patch is for mozilla-central and mozilla-aurora, the second one for mozilla-beta. No approvals needed, everything is testonly.
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca56b87ab094
Turn on javascript.options.asyncstack pref for Netmonitor tests that need it. r=ochameau
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ca56b87ab094
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.