1303800 - Beta devtools tests failing with browser_net_cause.js | A promise chain failed to handle a rejection: - at chrome://mochitests/content/browser/devtools/client/netmonitor/test/browser_net_cause.js:118 - TypeError: stacktrace[j] is undefined

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect)

Description

[Treeherder Bug Filer]

Filed by: wkocher [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=1608145&repo=mozilla-beta

https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-beta-win32-debug/1474292431/mozilla-beta_win7_vm-debug_test-mochitest-e10s-devtools-chrome-4-bm128-tests1-windows-build7.txt.gz

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Jarda, can you take a look at this, please?

Comment 2

[Jarda Snajdr [:jsnajdr]]

The test depends on javascript.options.asyncstack being set to "true". It's indeed "true" in central and aurora, but isn't when defined(RELEASE_BUILD). Is RELEASE_BUILD defined both in mozilla-release and mozilla-beta?

I'll post a simple fix soon.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Thanks. Yes, RELEASE_BUILD is true for beta and release.

Comment 4

[Intermittent Failures Robot]

19 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-beta: 19

Platform breakdown:
* linux64: 5
* windows7-32-vm: 4
* windows8-64: 3
* linux32: 3
* windowsxp: 2
* osx-10-10: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1303800&startday=2016-09-19&endday=2016-09-19&tree=all

Comment 5

[Jarda Snajdr [:jsnajdr]]

Attachment: Turn on javascript.options.asyncstack pref for Netmonitor tests that need it

Version of the patch intended for mozilla-central - patch browser_net_cause.js and browser_net_frame.js to turn on javascript.options.asyncstack.

The patch for mozilla-beta will be slightly different.

Comment 6

[Jarda Snajdr [:jsnajdr]]

Attachment: Turn on javascript.options.asyncstack pref for Netmonitor tests that need it (beta)

Version of the patch for mozilla-beta. Fixes only browser_net_cause.js, as browser_net_frame.js in only in aurora now. Also, properly rebased for mozilla-beta.

Comment 7

[Jarda Snajdr [:jsnajdr]]

Please checkin. One patch is for mozilla-central and mozilla-aurora, the second one for mozilla-beta. No approvals needed, everything is testonly.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca56b87ab094
Turn on javascript.options.asyncstack pref for Netmonitor tests that need it. r=ochameau

Comment 9

[Carsten Book [:Tomcat]]

aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/f16332940adb
beta: https://hg.mozilla.org/releases/mozilla-beta/rev/846d7032d2e0

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ca56b87ab094

Comment 11

[Intermittent Failures Robot]

28 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-beta: 28

Platform breakdown:
* linux64: 10
* linux32: 6
* windows8-64: 4
* windows7-32-vm: 4
* windowsxp: 2
* osx-10-10: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1303800&startday=2016-09-19&endday=2016-09-25&tree=all