1303826 - incorrect capitalization when color cycling with color swatch

Status: VERIFIED FIXED

(DevTools :: Framework, enhancement, P1)

Description

[Tom Tromey :tromey]

Make a page with "background: #000".
Open the rule view.
Use the color swatch to cycle the color.

Here the results are in upper case, like "RGB(0, 0, 0)" or "BLACK".
This seems weird; I think they should be lower-case by default.

I suspect this is a regression from some earlier change in this track.

Comment 1

[Tom Tromey :tromey]

Attachment: Bug 1303826 - don't select upper-case color names by default;

Review commit: https://reviewboard.mozilla.org/r/79866/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79866/

Comment 2

[Greg Tatum [:gregtatum] (REO Fx132)]

Comment on attachment 8793055 [details]
Bug 1303826 - don't select upper-case color names by default;

https://reviewboard.mozilla.org/r/79866/#review78878

Works for me, I just came across this while working on my bug. Good to see a fix for it.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bad89ed877c2
don't select upper-case color names by default; r=gregtatum

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bad89ed877c2

Comment 5

[Petruta Horea [:phorea], Desktop Test Engineering]

Verified as fixed using Nightly 52.0a1 2016-09-23 under Win 10 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.11.